Skip to content

docs(moe): record #144 option 1 — engram mmap + K-quant shipped - #207

Merged
rmems merged 2 commits into
mainfrom
cursor/gguf-engram-mmap-decision-d425
Sep 26, 2026
Merged

rmems merged 2 commits into
mainfrom
cursor/gguf-engram-mmap-decision-d425

Conversation

@rmems

@rmems rmems commented Sep 15, 2026 •

Copy link
Copy Markdown
Owner

User description

Summary

Records the #144 decision on the GGUF → engram-parser path. Docs and one module-doc only — no code, no behaviour, no Cargo.toml change.

Decision

Option 1 — upstream first, adopt second. Do not close #115 as won't-do.

rmems/engram-parser#45 shipped in rmems/engram-parser#73:

  • Optional mmap feature (memmap2); default load_gguf stays fs::read / zero-dep
  • Packed CPU dequant for Q8_0, Q5_K, Q6_K, IQ3_M (internal block layout)
  • CUDA host-register remains out of scope in engram-parser

#115 is therefore unblocked. Consume parse/mmap/packed dequant from engram-parser (git dep until a post-0.2.0 crates.io release); keep CUDA host-register here.

This is the same "upstream first" shape as #119 / #143. Sharing the #116 way (one-way copy, no dep) is the rejected alternative.

What changed in this PR

Refs #144, #115, rmems/engram-parser#45, RM-237


Summary by cubic

Records the #144 decision to take GGUF parsing upstream first: rmems/engram-parser #73 shipped an optional mmap feature and packed Q8_0/Q5_K/Q6_K dequant, closing #45 and unblocking #115. Docs and module-doc only, so no code, behavior, or Cargo.toml changes; CUDA host-register stays in this crate. Updates docs/MODULE_STATUS.md, manifests/proven_components.toml, docs/PROMOTION_RULES.md, and src/moe/gguf/mod.rs.

Written for commit 78a6032. Summary will update on new commits.

Review in cubic

Note

Low Risk
Docs and module comments only; no code paths, dependencies, or behavior change.

Overview
Documentation-only update recording #144 option 1 (upstream first, adopt second) for the GGUF → rmems/engram-parser path. No runtime, dependency, or Cargo.toml changes.

docs/MODULE_STATUS.md, manifests/proven_components.toml, and docs/PROMOTION_RULES.md now state that rmems/engram-parser#73 shipped optional mmap plus packed Q8_0 / Q5_K / Q6_K / IQ3_M dequant (closes engram-parser#45), so #115 is unblocked to adopt parse/mmap/packed dequant from engram-parser while CUDA host-register stays in this repo. Wording shifts from “parse half only / blocked by #144” to parse + mmap + packed K-quant as the consumable surface.

src/moe/gguf/mod.rs adds module-level comments describing the same #115 consume contract at the GGUF implementation site.

Reviewed by Cursor Bugbot for commit bf2d540. Bugbot is set up for automated code reviews on this repo. Configure here.


CodeAnt-AI Description

Record the GGUF upstream-first decision and its unblocked adoption path

What Changed

Impact

✅ Clearer GGUF component ownership
✅ Unblocked engram-parser adoption
✅ Accurate mmap and quantization capability tracking

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

@coderabbitai

coderabbitai Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 5256960d-a553-4e8d-a203-7555ce71a161


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation update accurately records decision #144 (option 1: upstream first, adopt second) across all relevant files. The changes consistently document that optional mmap + Q8_0/Q5_K/Q6_K/IQ3_M packed dequant shipped in rmems/engram-parser#73, unblocking #115. All documentation files (MODULE_STATUS.md, PROMOTION_RULES.md, proven_components.toml, and module comment in src/moe/gguf/mod.rs) are synchronized and correctly reflect the decision. No code or behavior changes as stated in the PR description.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@rmems
rmems marked this pull request as ready for review September 15, 2026 05:13
@codeant-ai

codeant-ai Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Incremental review completed 78a6032 Sep 22, 2026 · 09:50 09:51
✅ Reviewed your PR bf2d540 Sep 15, 2026 · 05:13 05:14

@codeant-ai

codeant-ai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@cursor

cursor Bot commented Sep 15, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_e0122b93-a8e2-4753-826a-74e47916a222)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-15T05:17:54.245206Z bf2d540 Draft marked ready
🔒 Security Review ✅ Completed 2026-09-15T05:15:17.844528Z bf2d540 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codeant-ai codeant-ai Bot added the size:S This PR changes 10-29 lines, ignoring generated files label Sep 15, 2026
@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bf2d540945

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/PROMOTION_RULES.md Outdated
Comment thread src/moe/gguf/mod.rs Outdated
@github-actions

Copy link
Copy Markdown

✅ GPU CUDA Build Validation Passed

Runner: ShipOfTheseus (RTX 5080)
Validation: CUDA lib-test compile + example compile in Ubuntu 22.04 / CUDA 13.2 toolchain
CUDA: 13.2+ (sm_120)
View logs

@rmems rmems self-assigned this Sep 19, 2026
rmems and others added 2 commits September 22, 2026 09:49
Upstream first: rmems/engram-parser#73 closed #45 with an optional mmap
feature and packed Q8_0/Q5_K/Q6_K/IQ3_M dequant. Unblock #115; CUDA
host-register stays in this crate.
Rebase onto main for rustls >=0.23.45 (RUSTSEC-2026-0285). Align promotion
docs with mod.rs: #115 will consume engram-parser once adopted; IQ3_M_BLOCK
is internal-only, not a GGUF wire type.

Co-authored-by: Raul Cardenas Montoya <montoyaraul34@gmail.com>
@cursor
cursor Bot force-pushed the cursor/gguf-engram-mmap-decision-d425 branch from bf2d540 to 78a6032 Compare September 22, 2026 09:50
@github-actions

Copy link
Copy Markdown

✅ GPU CUDA Build Validation Passed

Runner: ShipOfTheseus (RTX 5080)
Validation: CUDA lib-test compile + example compile in Ubuntu 22.04 / CUDA 13.2 toolchain
CUDA: 13.2+ (sm_120)
View logs

@rmems
rmems merged commit 75acc44 into main Sep 26, 2026
16 checks passed
@rmems
rmems deleted the cursor/gguf-engram-mmap-decision-d425 branch September 26, 2026 04:42
@linear-code

linear-code Bot commented Sep 26, 2026

Copy link
Copy Markdown

RM-1838

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

moe: migrate GGUF parser layer to engram-parser dep (extract useful code from experimental ref impl)

2 participants