Repository navigation
docs(moe): record #144 option 1 — engram mmap + K-quant shipped - #207
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Documentation update accurately records decision #144 (option 1: upstream first, adopt second) across all relevant files. The changes consistently document that optional mmap + Q8_0/Q5_K/Q6_K/IQ3_M packed dequant shipped in rmems/engram-parser#73, unblocking #115. All documentation files (MODULE_STATUS.md, PROMOTION_RULES.md, proven_components.toml, and module comment in src/moe/gguf/mod.rs) are synchronized and correctly reflect the decision. No code or behavior changes as stated in the PR description.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
Up to standards ✅🟢 Issues
|
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_e0122b93-a8e2-4753-826a-74e47916a222) |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf2d540945
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
✅ GPU CUDA Build Validation Passed Runner: ShipOfTheseus (RTX 5080) |
Upstream first: rmems/engram-parser#73 closed #45 with an optional mmap feature and packed Q8_0/Q5_K/Q6_K/IQ3_M dequant. Unblock #115; CUDA host-register stays in this crate.
Rebase onto main for rustls >=0.23.45 (RUSTSEC-2026-0285). Align promotion docs with mod.rs: #115 will consume engram-parser once adopted; IQ3_M_BLOCK is internal-only, not a GGUF wire type. Co-authored-by: Raul Cardenas Montoya <montoyaraul34@gmail.com>
bf2d540 to
78a6032
Compare
|
✅ GPU CUDA Build Validation Passed Runner: ShipOfTheseus (RTX 5080) |
User description
Summary
Records the #144 decision on the GGUF → engram-parser path. Docs and one module-doc only — no code, no behaviour, no
Cargo.tomlchange.Decision
Option 1 — upstream first, adopt second. Do not close #115 as won't-do.
rmems/engram-parser#45shipped inrmems/engram-parser#73:mmapfeature (memmap2); defaultload_ggufstaysfs::read/ zero-dep#115 is therefore unblocked. Consume parse/mmap/packed dequant from engram-parser (git dep until a post-0.2.0 crates.io release); keep CUDA host-register here.
This is the same "upstream first" shape as #119 / #143. Sharing the #116 way (one-way copy, no dep) is the rejected alternative.
What changed in this PR
docs/MODULE_STATUS.mdGGUF rows: engram-parser: mmap reader + K-quant dequant required before #115 is viable #144 option 1, docs(model-onboarding): add rollout lineup document for onboarding batches #45/Add New Relic telemetry verification, prompt-vector coverage, and SAAQ formula comparison #73 shipped, moe: migrate GGUF parser layer to engram-parser dep (extract useful code from experimental ref impl) #115 unblockedmanifests/proven_components.toml— machine-readable mirror, same notesdocs/PROMOTION_RULES.mdOne-way extractions GGUF bullet: no longer "blocked by engram-parser: mmap reader + K-quant dequant required before #115 is viable #144"src/moe/gguf/mod.rsmodule doc names the consume contract at the edit siteRefs #144, #115, rmems/engram-parser#45, RM-237
Summary by cubic
Records the #144 decision to take GGUF parsing upstream first:
rmems/engram-parser#73 shipped an optionalmmapfeature and packed Q8_0/Q5_K/Q6_K dequant, closing #45 and unblocking #115. Docs and module-doc only, so no code, behavior, orCargo.tomlchanges; CUDA host-register stays in this crate. Updatesdocs/MODULE_STATUS.md,manifests/proven_components.toml,docs/PROMOTION_RULES.md, andsrc/moe/gguf/mod.rs.IQ3_Mstays out of the consumed surface: it's internal-only packed dequant, not a GGUF wire type, and moe: migrate GGUF parser layer to engram-parser dep (extract useful code from experimental ref impl) #115 will adopt parse/mmap/packed dequant from engram-parser once it lands.Written for commit 78a6032. Summary will update on new commits.
Note
Low Risk
Docs and module comments only; no code paths, dependencies, or behavior change.
Overview
Documentation-only update recording #144 option 1 (upstream first, adopt second) for the GGUF →
rmems/engram-parserpath. No runtime, dependency, orCargo.tomlchanges.docs/MODULE_STATUS.md,manifests/proven_components.toml, anddocs/PROMOTION_RULES.mdnow state that rmems/engram-parser#73 shipped optionalmmapplus packed Q8_0 / Q5_K / Q6_K / IQ3_M dequant (closes engram-parser#45), so #115 is unblocked to adopt parse/mmap/packed dequant from engram-parser while CUDA host-register stays in this repo. Wording shifts from “parse half only / blocked by #144” to parse + mmap + packed K-quant as the consumable surface.src/moe/gguf/mod.rsadds module-level comments describing the same #115 consume contract at the GGUF implementation site.Reviewed by Cursor Bugbot for commit bf2d540. Bugbot is set up for automated code reviews on this repo. Configure here.
CodeAnt-AI Description
Record the GGUF upstream-first decision and its unblocked adoption path
What Changed
Impact
✅ Clearer GGUF component ownership✅ Unblocked engram-parser adoption✅ Accurate mmap and quantization capability tracking💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.