Skip to content

Commit

Permalink
removed reserved words restriction for bundle identifier
Browse files Browse the repository at this point in the history
  • Loading branch information
mas192 committed May 21, 2024
1 parent 8817325 commit 68aeab4
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 11 deletions.
1 change: 0 additions & 1 deletion tests/commands/new/test_validate_bundle.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ def test_valid_bundle(new_command, bundle):
"com.hello_world", # underscore
"com.hello,world", # comma
"com.hello world!", # exclamation point
"com.pass.example", # Reserved word
],
)
def test_invalid_bundle(new_command, bundle):
Expand Down
4 changes: 0 additions & 4 deletions tests/config/test_AppConfig.py
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,6 @@ def test_valid_bundle(bundle):
"com.hello_world", # underscore
"com.hello,world", # comma
"com.hello world!", # exclamation point
"com.pass", # Python reserved word
"com.pass.example", # Python reserved word
"com.switch", # Java reserved word
"com.switch.example", # Java reserved word
],
)
def test_invalid_bundle_identifier(bundle):
Expand Down
6 changes: 0 additions & 6 deletions tests/config/test_is_valid_bundle_identifier.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,6 @@ def test_valid_bundle(bundle):
"com.hello_world", # underscore
"com.hello,world", # comma
"com.hello world!", # exclamation point
"com.pass", # Python reserved word
"com.pass.example", # Python reserved word
"com.switch", # Java reserved word
"com.switch.example", # Java reserved word
"int.example", # Valid identifier with a reserved word as the TLD
"do.example", # This *should* be valid by the Java spec, but Android chokes.
],
)
def test_invalid_bundle(bundle):
Expand Down

0 comments on commit 68aeab4

Please sign in to comment.