Fix sh1106 display of a rotated image

[cjmayo]

The rotated width was being used instead of the physical width.

---

Closes #275

[gemini-code-assist]

Summary of Changes

Hello @cjmayo, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've addressed an issue where the SH1106 display was incorrectly rendering rotated images. The core problem was that the display logic was using the rotated image's width for internal calculations, rather than the physical width of the display. This led to incorrect pixel mapping and display artifacts. My changes ensure that the correct physical dimensions are always used for rendering, resolving the display anomaly.

Highlights

• Display Logic Correction: I've updated the display method in luma/oled/device/__init__.py to use the physical display width (self._w) instead of the potentially rotated image width (self.width) when calculating buffer sizes and pixel offsets. This ensures that images, especially rotated ones, are rendered correctly on the SH1106 display.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses an issue with displaying rotated images on the sh1106 device. By replacing the logical self.width with the physical self._w for display buffer calculations, the code now correctly handles transformations for rotated displays. This is a clean and accurate fix for the described problem. The change is well-contained and I have no further suggestions.