Add support for ST7789 #141

matemaciek · 2021-03-12T20:05:43Z

#109 Rebased over current master.

fixes #104

Co-authored-by: Richard Hull <rm_hull@yahoo.co.uk>

…r displays

thijstriemstra

thanks!

luma/lcd/device.py

tests/test_st7789.py

rm-hull · 2021-03-13T16:55:46Z

luma/lcd/device.py

+        super(st7789, self).__init__(luma.lcd.const.st7789, serial_interface, **kwargs)
+        self.capabilities(240, 240, rotate, mode="RGB")
+
+        self.command(0x36)


I think it may be possible to combine:

self.command(0x36) self.data([0x70])

into:

self.command(0x36, 0x70)

have a look at the implementation for command for more details

Also it would be quite nice to document each command, eg like: https://github.com/rm-hull/luma.lcd/blob/master/luma/lcd/device.py#L460-L482

Also here you can see the combined command/data

Yeah, I like this combined syntax more, I wonder why author of the original PR went that way.

rm-hull

Great effort @matemaciek! it would good to get this in "as-is" (with the PR comments resolved), and then look at another PR with an improved implementation that makes use of the framebuffering for better performance (see https://github.com/rm-hull/luma.lcd/blob/master/luma/lcd/device.py#L501-L508 for example)

matemaciek · 2021-03-13T17:13:49Z

Glad you like it (-:

Let me implement review remarks.

matemaciek · 2021-03-13T20:04:11Z

OK, significant speedup is on the way

matemaciek · 2021-03-13T20:47:58Z

examples/perfloop.py on Pi Zero has ~10.5fps with this version.

thijstriemstra · 2021-03-13T20:49:18Z

examples/perfloop.py on Pi Zero has ~10.5fps with this version.

And before?

matemaciek · 2021-03-13T20:54:21Z

<1fps

iceman1001 · 2021-03-14T16:39:25Z

Love this!
Is it possible to install this with pip ?

sudo python3 -m pip install --upgrade luma.lcd seem to install the 2020 December release.

matemaciek · 2021-03-14T17:02:08Z

I think there has been no release yet, it should land in 2.9.0

iceman1001 · 2021-03-14T17:12:10Z

Hm, can't find a release schedule...
Looks like I have to clone and install it..

thijstriemstra · 2021-03-14T17:21:22Z

release schedule is in CHANGES.md. It'll be released within a few days I expect.

iceman1001 · 2021-03-14T17:58:26Z

no problem , I installed it locally. Excited to test it out. Been having this waveshare shield for some time and no easy way to use it.

matemaciek · 2021-03-14T18:07:41Z

I developed on waveshare shield to, let me share some commands...

matemaciek · 2021-03-14T18:11:02Z

Running examples from luma.examples:
python3 examples/bounce.py -i spi -d st7789 --gpio-reset 27 --gpio-data-command 25 --gpio-backlight 24 --backlight-active high --spi-bus-speed 52000000

Python:

from PIL import Image
import luma.core.interface.serial
import luma.lcd.device
image = Image.open("/home/pi/logo.png").resize((240,240))
serial = luma.core.interface.serial.spi(gpio_DC=25, gpio_RST=27, bus_speed_hz=52000000)
device = luma.lcd.device.st7789(serial, gpio_LIGHT=24, active_low=False)
device.display(image)

thijstriemstra · 2021-03-14T18:19:44Z

@matemaciek can you add that config to luma.examples/config/ ?

matemaciek · 2021-03-14T18:32:03Z

Sure! Also just testing on pi 4, ~21.5fps \o/

iceman1001 · 2021-03-14T18:35:52Z

odd.. is there a discord where we can chat? I don't want to pollute this closed issue..

pi@raspberrypi:~/luma.lcd $  python3 setup.py build
pi@raspberrypi:~/luma.lcd $  sudo python3 setup.py install
....

pi@raspberrypi:~/luma.lcd $  python3
Python 3.7.3 (default, Jul 25 2020, 13:03:44)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import luma.lcd
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'luma.lcd'
>>>

matemaciek · 2021-03-14T18:38:33Z

I install with sudo python3 setup.py develop

rm-hull · 2021-03-14T18:41:58Z

@thijstriemstra im trying to upload to pypi, but fails .. any ideas:

$ python3 setup.py clean sdist bdist_wheel upload -r pypi
running clean
running sdist
running egg_info
writing luma.lcd.egg-info/PKG-INFO
writing dependency_links to luma.lcd.egg-info/dependency_links.txt
writing namespace_packages to luma.lcd.egg-info/namespace_packages.txt
writing requirements to luma.lcd.egg-info/requires.txt
writing top-level names to luma.lcd.egg-info/top_level.txt
reading manifest file 'luma.lcd.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
no previously-included directories found matching 'doc/_build'
warning: no previously-included files matching '__pycache__' found under directory '*'
warning: no previously-included files matching '*.py[co]' found under directory '*'
warning: no previously-included files matching '*~' found under directory '*'
warning: no previously-included files matching '.coverage' found under directory '*'
warning: no previously-included files matching '.DS_Store' found under directory '*'
warning: no previously-included files matching '.ropeproject' found under directory '*'
writing manifest file 'luma.lcd.egg-info/SOURCES.txt'
running check
creating luma.lcd-2.9.0
creating luma.lcd-2.9.0/doc
creating luma.lcd-2.9.0/doc/fritzing
creating luma.lcd-2.9.0/doc/images
creating luma.lcd-2.9.0/doc/old
creating luma.lcd-2.9.0/doc/tech-spec
creating luma.lcd-2.9.0/luma
creating luma.lcd-2.9.0/luma.lcd.egg-info
creating luma.lcd-2.9.0/luma/lcd
copying files to luma.lcd-2.9.0...
copying .coveragerc -> luma.lcd-2.9.0
copying CHANGES.rst -> luma.lcd-2.9.0
copying CONTRIBUTING.rst -> luma.lcd-2.9.0
copying LICENSE.rst -> luma.lcd-2.9.0
copying MANIFEST.in -> luma.lcd-2.9.0
copying README.rst -> luma.lcd-2.9.0
copying pyproject.toml -> luma.lcd-2.9.0
copying pytest.ini -> luma.lcd-2.9.0
copying setup.cfg -> luma.lcd-2.9.0
copying setup.py -> luma.lcd-2.9.0
copying tox.ini -> luma.lcd-2.9.0
copying doc/HD44780.rst -> luma.lcd-2.9.0/doc
copying doc/Makefile -> luma.lcd-2.9.0/doc
copying doc/api-documentation.rst -> luma.lcd-2.9.0/doc
copying doc/conf.py -> luma.lcd-2.9.0/doc
copying doc/hardware.rst -> luma.lcd-2.9.0/doc
copying doc/index.rst -> luma.lcd-2.9.0/doc
copying doc/install.rst -> luma.lcd-2.9.0/doc
copying doc/intro.rst -> luma.lcd-2.9.0/doc
copying doc/python-usage.rst -> luma.lcd-2.9.0/doc
copying doc/references.rst -> luma.lcd-2.9.0/doc
copying doc/software.rst -> luma.lcd-2.9.0/doc
copying doc/fritzing/PCD8544 LCD.fzpz -> luma.lcd-2.9.0/doc/fritzing
copying doc/fritzing/RPi GPIO Header.fzpz -> luma.lcd-2.9.0/doc/fritzing
copying doc/fritzing/schematic.fzz -> luma.lcd-2.9.0/doc/fritzing
copying doc/images/IMG_2539.JPG -> luma.lcd-2.9.0/doc/images
copying doc/images/IMG_2540.JPG -> luma.lcd-2.9.0/doc/images
copying doc/images/IMG_2541.JPG -> luma.lcd-2.9.0/doc/images
copying doc/images/IMG_2544.JPG -> luma.lcd-2.9.0/doc/images
copying doc/images/IMG_2774.JPG -> luma.lcd-2.9.0/doc/images
copying doc/images/RPi_P5_header.png -> luma.lcd-2.9.0/doc/images
copying doc/images/clock_anim.gif -> luma.lcd-2.9.0/doc/images
copying doc/images/crawl_anim.gif -> luma.lcd-2.9.0/doc/images
copying doc/images/hd44780_20x4.jpg -> luma.lcd-2.9.0/doc/images
copying doc/images/hd44780_clock.jpg -> luma.lcd-2.9.0/doc/images
copying doc/images/hd44780_progress.jpg -> luma.lcd-2.9.0/doc/images
copying doc/images/ht1621.jpg -> luma.lcd-2.9.0/doc/images
copying doc/images/ili9341.jpg -> luma.lcd-2.9.0/doc/images
copying doc/images/invaders_anim.gif -> luma.lcd-2.9.0/doc/images
copying doc/images/pcd8544.jpg -> luma.lcd-2.9.0/doc/images
copying doc/images/pcd8544.png -> luma.lcd-2.9.0/doc/images
copying doc/images/pcd8544.svg -> luma.lcd-2.9.0/doc/images
copying doc/images/pcd8544_schematic_bb.png -> luma.lcd-2.9.0/doc/images
copying doc/images/serial_config.jpg -> luma.lcd-2.9.0/doc/images
copying doc/images/st7567.jpg -> luma.lcd-2.9.0/doc/images
copying doc/images/st7735.jpg -> luma.lcd-2.9.0/doc/images
copying doc/images/st7735_pin_outs.jpg -> luma.lcd-2.9.0/doc/images
copying doc/images/st7735_schematic_bb.png -> luma.lcd-2.9.0/doc/images
copying doc/images/uc1701x.png -> luma.lcd-2.9.0/doc/images
copying doc/images/wiring-diagram.png -> luma.lcd-2.9.0/doc/images
copying doc/images/wiring-diagram.svg -> luma.lcd-2.9.0/doc/images
copying doc/old/veroboard-schematic.diy -> luma.lcd-2.9.0/doc/old
copying doc/tech-spec/HD44780.pdf -> luma.lcd-2.9.0/doc/tech-spec
copying doc/tech-spec/HT1621.pdf -> luma.lcd-2.9.0/doc/tech-spec
copying doc/tech-spec/ILI9341.pdf -> luma.lcd-2.9.0/doc/tech-spec
copying doc/tech-spec/PCD8544.pdf -> luma.lcd-2.9.0/doc/tech-spec
copying doc/tech-spec/ST7735.pdf -> luma.lcd-2.9.0/doc/tech-spec
copying doc/tech-spec/ST7789.pdf -> luma.lcd-2.9.0/doc/tech-spec
copying doc/tech-spec/ST7920.pdf -> luma.lcd-2.9.0/doc/tech-spec
copying doc/tech-spec/UC1701X.pdf -> luma.lcd-2.9.0/doc/tech-spec
copying luma/__init__.py -> luma.lcd-2.9.0/luma
copying luma.lcd.egg-info/PKG-INFO -> luma.lcd-2.9.0/luma.lcd.egg-info
copying luma.lcd.egg-info/SOURCES.txt -> luma.lcd-2.9.0/luma.lcd.egg-info
copying luma.lcd.egg-info/dependency_links.txt -> luma.lcd-2.9.0/luma.lcd.egg-info
copying luma.lcd.egg-info/namespace_packages.txt -> luma.lcd-2.9.0/luma.lcd.egg-info
copying luma.lcd.egg-info/not-zip-safe -> luma.lcd-2.9.0/luma.lcd.egg-info
copying luma.lcd.egg-info/requires.txt -> luma.lcd-2.9.0/luma.lcd.egg-info
copying luma.lcd.egg-info/top_level.txt -> luma.lcd-2.9.0/luma.lcd.egg-info
copying luma/lcd/__init__.py -> luma.lcd-2.9.0/luma/lcd
copying luma/lcd/const.py -> luma.lcd-2.9.0/luma/lcd
copying luma/lcd/device.py -> luma.lcd-2.9.0/luma/lcd
copying luma/lcd/segment_mapper.py -> luma.lcd-2.9.0/luma/lcd
Writing luma.lcd-2.9.0/setup.cfg
Creating tar archive
removing 'luma.lcd-2.9.0' (and everything under it)
running bdist_wheel
running build
running build_py
installing to build/bdist.macosx-11-arm64/wheel
running install
running install_lib
Skipping installation of build/bdist.macosx-11-arm64/wheel/luma/__init__.py (namespace package)
copying luma/lcd/device.py -> build/bdist.macosx-11-arm64/wheel/luma/lcd
copying luma/lcd/__init__.py -> build/bdist.macosx-11-arm64/wheel/luma/lcd
copying luma/lcd/segment_mapper.py -> build/bdist.macosx-11-arm64/wheel/luma/lcd
copying luma/lcd/const.py -> build/bdist.macosx-11-arm64/wheel/luma/lcd
running install_egg_info
Copying luma.lcd.egg-info to build/bdist.macosx-11-arm64/wheel/luma.lcd-2.9.0-py3.9.egg-info
Installing build/bdist.macosx-11-arm64/wheel/luma.lcd-2.9.0-py3.9-nspkg.pth
running install_scripts
adding license file "LICENSE.rst" (matched pattern "LICEN[CS]E*")
creating build/bdist.macosx-11-arm64/wheel/luma.lcd-2.9.0.dist-info/WHEEL
creating 'dist/luma.lcd-2.9.0-py2.py3-none-any.whl' and adding 'build/bdist.macosx-11-arm64/wheel' to it
adding 'luma.lcd-2.9.0-py3.9-nspkg.pth'
adding 'luma/lcd/__init__.py'
adding 'luma/lcd/const.py'
adding 'luma/lcd/device.py'
adding 'luma/lcd/segment_mapper.py'
adding 'luma.lcd-2.9.0.dist-info/LICENSE.rst'
adding 'luma.lcd-2.9.0.dist-info/METADATA'
adding 'luma.lcd-2.9.0.dist-info/WHEEL'
adding 'luma.lcd-2.9.0.dist-info/namespace_packages.txt'
adding 'luma.lcd-2.9.0.dist-info/top_level.txt'
adding 'luma.lcd-2.9.0.dist-info/RECORD'
removing build/bdist.macosx-11-arm64/wheel
running upload
Submitting dist/luma.lcd-2.9.0.tar.gz to https://upload.pypi.org/legacy/
Upload failed (400): Invalid value for blake2_256_digest. Error: Use a valid, hex-encoded, BLAKE2 message digest.
error: Upload failed (400): Invalid value for blake2_256_digest. Error: Use a valid, hex-encoded, BLAKE2 message digest.

iceman1001 · 2021-03-14T19:25:36Z

@matemaciek the develop install worked!!!! Yesssss!!!

thijstriemstra · 2021-03-14T21:26:18Z

@rm-hull upgrade wheel and setuptools to latest and try again?

thijstriemstra · 2021-03-14T21:28:33Z

also looks like its trying to build for arm:

build/bdist.macosx-11-arm64/wheel

thijstriemstra · 2021-03-14T21:29:20Z

would be better to publish using github actions only to prevent these issues @rm-hull

rm-hull · 2021-03-14T21:52:22Z

also looks like its trying to build for arm:

build/bdist.macosx-11-arm64/wheel

ah yes ... that will be my shiny new macbook

rm-hull · 2021-03-15T11:26:53Z

Publishes ok on linux...

https://pypi.org/project/luma.lcd/2.9.0/ released

rm-hull and others added 2 commits March 12, 2021 16:36

Documentation

a70106a

ST7789 support (#92)

bd00ea8

Co-authored-by: Richard Hull <rm_hull@yahoo.co.uk>

matemaciek changed the base branch from feature/st7789 to master March 12, 2021 20:06

matemaciek added 5 commits March 12, 2021 23:09

Move from numpy to python for st7789.display

051a328

Make flake happy

5a4db35

Add tests for st7789, change implementation to more in line with othe…

34148a0

…r displays

QA remarks

f4d9431

Contrast test

66db553

matemaciek mentioned this pull request Mar 13, 2021

Add support for 1.3" ST7789 (240x240) colour LCD driver (replaces #80) #109

Closed

thijstriemstra requested changes Mar 13, 2021

View reviewed changes

luma/lcd/device.py Show resolved Hide resolved

tests/test_st7789.py Outdated Show resolved Hide resolved

rm-hull reviewed Mar 13, 2021

View reviewed changes

rm-hull requested changes Mar 13, 2021

View reviewed changes

Review remarks addressed

2a2802a

matemaciek requested a review from rm-hull March 13, 2021 19:16

Performance improvement for st7789

748ff97

thijstriemstra changed the title ~~feature/st7789~~ Add support for ST7789 Mar 13, 2021

thijstriemstra approved these changes Mar 13, 2021

View reviewed changes

rm-hull approved these changes Mar 14, 2021

View reviewed changes

rm-hull merged commit 093e53f into rm-hull:master Mar 14, 2021

thijstriemstra added the enhancement label Mar 14, 2021

Add support for ST7789 #141

Add support for ST7789 #141

Uh oh!

Conversation

matemaciek commented Mar 12, 2021 • edited by thijstriemstra Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thijstriemstra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rm-hull Mar 13, 2021

Choose a reason for hiding this comment

Uh oh!

rm-hull Mar 13, 2021

Choose a reason for hiding this comment

Uh oh!

matemaciek Mar 13, 2021

Choose a reason for hiding this comment

Uh oh!

rm-hull left a comment

Choose a reason for hiding this comment

Uh oh!

matemaciek commented Mar 13, 2021

Uh oh!

matemaciek commented Mar 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matemaciek commented Mar 13, 2021

Uh oh!

thijstriemstra commented Mar 13, 2021

Uh oh!

matemaciek commented Mar 13, 2021

Uh oh!

iceman1001 commented Mar 14, 2021

Uh oh!

matemaciek commented Mar 14, 2021

Uh oh!

iceman1001 commented Mar 14, 2021

Uh oh!

thijstriemstra commented Mar 14, 2021

Uh oh!

iceman1001 commented Mar 14, 2021

Uh oh!

matemaciek commented Mar 14, 2021

Uh oh!

matemaciek commented Mar 14, 2021

Uh oh!

thijstriemstra commented Mar 14, 2021

Uh oh!

matemaciek commented Mar 14, 2021

Uh oh!

iceman1001 commented Mar 14, 2021

Uh oh!

matemaciek commented Mar 14, 2021

Uh oh!

rm-hull commented Mar 14, 2021

Uh oh!

iceman1001 commented Mar 14, 2021

Uh oh!

thijstriemstra commented Mar 14, 2021

Uh oh!

thijstriemstra commented Mar 14, 2021

Uh oh!

thijstriemstra commented Mar 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rm-hull commented Mar 14, 2021

Uh oh!

rm-hull commented Mar 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

matemaciek commented Mar 12, 2021 •

edited by thijstriemstra

Loading

matemaciek commented Mar 13, 2021 •

edited

Loading

thijstriemstra commented Mar 14, 2021 •

edited

Loading