feat: add --no-verify flag to skip git hooks#141
Conversation
Introduced the `--no-verify` flag to allow bypassing pre-commit or commit-msg hooks during the commit process, mirroring native git functionality. Updated the CLI parser, application flow, and internal Git client to propagate this option.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Code Review
This pull request introduces a new --no-verify flag to skip git commit hooks, propagating it from the CLI to the git client. Feedback focuses on correcting the terminology of the flag's description in the README and CLI help text (as Git uses pre-commit and commit-msg hooks rather than 'pre-verify' hooks). Additionally, it is recommended to refactor the CLI flag binding to use a regular boolean variable instead of a pointer to avoid unnecessary dereferencing, and to group the growing list of boolean parameters in the application's Run method into a single configuration struct to eliminate a boolean parameter code smell.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Coverage Report for CI Build 28627657500Warning No base build found for commit Coverage: 31.188%Details
Uncovered Changes
Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
Consolidated multiple command-line arguments into a `RunOptions` struct
to simplify the signature of the `App.Run` method and improve
maintainability of CLI flags.
```mermaid
graph TD
A[main.go] -->|Populates| B(RunOptions)
B -->|Passed to| C[App.Run]
C -->|Uses| D[internal/app/app.go]
```
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a new --no-verify flag to bypass pre-commit and commit-msg hooks, and refactors the application to use a RunOptions struct for passing configuration options to the Run method. Feedback on these changes highlights two issues: the error returned by application.Run in main.go is currently ignored, and a potential nil pointer dereference could occur in internal/app/app.go if opts is nil.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
- Changed `Run` method signature to accept `RunOptions` by value instead of a pointer for consistency. - Updated `main.go` to initialize `RunOptions` as a value. - Added `handleError(err)` call in `main.go` to ensure application failures are properly reported.
…t/hooks * 'main' of github.com:rm-hull/git-commit-summary: feat: add `--no-verify` flag to skip git hooks (#141)
Introduced the
--no-verifyflag to allow bypassing pre-commit or commit-msg hooks during the commit process, mirroring native git functionality. Updated the CLI parser, application flow, and internal Git client to propagate this option.