Skip to content

Conversation

@James4Ever0
Copy link
Contributor

From #204

@jeffreysijuntan
Copy link
Contributor

Thank you for your contribution! Can you run pre-commit run --all-files to apply ruff formatter and then commit again with the changes?

Also, it would be nice to add this as an example to our official doc, so ppl can reference it. If you have existing training run results would be nice to share them there as well.

@jeffreysijuntan
Copy link
Contributor

Still seems to fail the check.. What command did you run locally?

@James4Ever0
Copy link
Contributor Author

James4Ever0 commented Sep 18, 2025

Still seems to fail the check.. What command did you run locally?

In the previous commit, I have tried to install precommit dependencies with uv, but stuck at flash-attn.

I then ran the following command according to .pre-commit-config.yaml:

cd examples/vimgolf
ruff check --fix --show-fixes --output-format=full

I guess there was something missing. I will run the following command afterwards.

cd examples/vimgolf
isort *.py
black *.py
ruff check --fix --show-fixes --output-format=full
ruff format

Is there a way to install only pre-commit dependencies (ruff) with uv?

@jeffreysijuntan jeffreysijuntan merged commit 0966d1a into rllm-org:main Sep 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants