Fix npm ERESOLVE and EJSONPARSE in package.json #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverqx
approved these changes
Dec 22, 2021
|
Is it possible to get this merged? I'm not sure how the peer dependency for docusaurus core was set to ^2.0.0 as ^2.0.0 doesn't exist yet. |
|
@rlamana Could you merge this if there's no problem? |
|
@Queue-ri merged, thanks for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for the work. I love your sass plugin.
This PR resolves two npm errors:
Commit 92a4884 resolves ERESOLVE.
npm 7 doesn't allow dependency conflict by default, but the peer dependency of
@docusaurus/corein package.json has a conflict. As you know, docusaurus v2 is not officially released yet; it is still in beta release. Reflecting a high demand(#19) of beta users, I fixed semver from^2.0.0to^2.0.0-betato handle the range of^2.0.0+ prereleases of 2.0.0. I know the conflict can be ignored locally with--legacy-peer-depsoption, however, it would be better to patch this since Dependabot can't PR@docusaurus/coreand the most docusaurus plugins handle beta versions.Commit d7cb7fd resolves EJSONPARSE.
JSON doesn't allow trailing commas in spec but there's a single trailing comma in package.json which causes EJSONPARSE. Fortunately, this bug is not included in v0.2.1 release. It is from the commit 287fcf2, so IMHO this should be fixed before the next release.
This PR closes #19.