WIP Add Vision capabilities via gpt 4o #123
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Nice work! What do you think about using (interactive (list
(read-file-name "Image file path: " nil nil nil (or (thing-at-point 'existing-filename)
(thing-at-point 'url)))
(read-string "Question: " nil 'minibuffer-history)))when querying the user? This would prefill the input when having the cursor over a filename or link. |
Contributor
Author
|
Makes sense, thanks for the suggestion! The only lisp I've ever written is for my own literate config 😬
|
tillydray
force-pushed
the
122/add-vision-capabilities-to-understand-images
branch
from
b147beb to
a6319fd
Compare
tillydray
force-pushed
the
122/add-vision-capabilities-to-understand-images
branch
from
665d6aa to
a9149c5
Compare
tillydray
commented
Oct 30, 2024
| (while (string-empty-p input) | ||
| (setq input | ||
| (read-string (if default | ||
| (format "Enter image URL or file path (default %s): " default) |
Contributor
Author
There was a problem hiding this comment.
consider adding "URL must start with http?s://
Contributor
Author
There was a problem hiding this comment.
feels bulky to add more text, and people probably already know that urls must start with http[s]:// in emacs right?
| (const :tag "gpt-4o" "gpt-4o") | ||
| (const :tag "gpt-4-turbo" "gpt-4-turbo"))) | ||
|
|
||
| (defcustom org-ai-query-image-file nil |
Contributor
Author
There was a problem hiding this comment.
@rksm you probably recognize this from org-ai-on-region-file, just calling attention in case you want me to do this in a different way
Owner
|
And happy to merge this. If you're OK with it, mark it ready for review. It does work well for me. We can improve the file selection a bit but otherwise looks really good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test, do
M-x org-ai-query-image-and-displayand follow prompts.related to #122