Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

done: bs-194 - migrating book APIs #222

Merged
merged 5 commits into from
Jan 16, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
wip: bs-194 - migrating book APIs
  • Loading branch information
rkshaon committed Jan 15, 2025
commit 3c9539b552a15ba1a5c5d59e2672c9d0d20e0f5c
9 changes: 5 additions & 4 deletions backend/book_api/urls/v1.py
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
from django.urls import path
# from django.urls import path
from rest_framework.routers import DefaultRouter

from book_api.views import v1


router = DefaultRouter()

router.register('', v1.BookViewSet, basename='book')
router.register('genre', v1.GenreViewSet, basename='genre')
router.register('topic', v1.TopicViewSet, basename='topic')

urlpatterns = [
path('', v1.BookView.as_view()),
path('<int:book_code>/', v1.BookView.as_view()),
path('search', v1.BookSearchView.as_view()),
# path('', v1.BookView.as_view()),
# path('<int:book_code>/', v1.BookView.as_view()),
# path('search', v1.BookSearchView.as_view()),
]

urlpatterns += router.urls
10 changes: 6 additions & 4 deletions backend/book_api/views/v1/__init__.py
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
from book_api.views.v1.book import BookView
# from book_api.views.v1.book import BookView
from book_api.views.v1.book import BookViewSet
from book_api.views.v1.genre import GenreViewSet
from book_api.views.v1.topic import TopicViewSet
from book_api.views.v1.search import BookSearchView
# from book_api.views.v1.search import BookSearchView


__all__ = [
BookView,
# BookView,
BookViewSet,
GenreViewSet,
TopicViewSet,
BookSearchView,
# BookSearchView,
]
146 changes: 80 additions & 66 deletions backend/book_api/views/v1/book.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from rest_framework.views import APIView
from rest_framework.viewsets import ModelViewSet
from rest_framework.response import Response
from rest_framework.permissions import AllowAny
from rest_framework.exceptions import NotFound
Expand All @@ -8,76 +9,89 @@

from BookShelf.utilities.pagination import Pagination
from BookShelf.utilities.permissions import IsAdminOrModerator
from BookShelf.utilities.filters import SearchFilter
from activity_api.utilities.event import event_logger

from book_api.models import Book

from book_api.serializers.v1 import BookSerializer


@method_decorator(cache_page(60*1), name='get')
class BookView(APIView):
permission_classes = [AllowAny]

def get(self, request, *args, **kwargs):
book_code = kwargs.get('book_code', None)
genre = request.query_params.get('genre', None)
topic = request.query_params.get('topic', None)

if book_code:
try:
book = Book.objects.get(book_code=book_code, is_deleted=False)
except Book.DoesNotExist:
raise NotFound(detail="Book not found.")

event_logger(
event='retrieve',
object='book',
user=request.user,
device=request.device,
ip_address=request.ip_address,
data={
'model': 'Book',
'id': book.id
}
)

return Response(BookSerializer(book).data)

books = Book.objects.filter(
is_deleted=False
)

if genre:
books = books.filter(genres__id=genre)

if topic:
books = books.filter(topics__id=topic)

books = books.order_by('-id')
paginator = Pagination()
page = paginator.paginate_queryset(books, request)

event_logger(
event='retrieve',
object='book',
user=request.user,
device=request.device,
ip_address=request.ip_address,
)

return paginator.get_paginated_response(
BookSerializer(page, many=True).data
)

def post(self, request, *args, **kwargs):
self.permission_classes = [IsAdminOrModerator]
self.check_permissions(request)
request.data['added_by'] = request.user.id
serializer = BookSerializer(
data=request.data,
)
serializer.is_valid(raise_exception=True)
serializer.save()

return Response(serializer.data, status=201)
class BookViewSet(ModelViewSet):
serializer_class = BookSerializer
queryset = Book.objects.filter(is_deleted=False)
permission_classes = [
IsAdminOrModerator,
]
filter_backends = [SearchFilter]
search_fields = ['title']




# @method_decorator(cache_page(60*1), name='get')
# class BookView(APIView):
# permission_classes = [AllowAny]

# def get(self, request, *args, **kwargs):
# book_code = kwargs.get('book_code', None)
# genre = request.query_params.get('genre', None)
# topic = request.query_params.get('topic', None)

# if book_code:
# try:
# book = Book.objects.get(book_code=book_code, is_deleted=False)
# except Book.DoesNotExist:
# raise NotFound(detail="Book not found.")

# event_logger(
# event='retrieve',
# object='book',
# user=request.user,
# device=request.device,
# ip_address=request.ip_address,
# data={
# 'model': 'Book',
# 'id': book.id
# }
# )

# return Response(BookSerializer(book).data)

# books = Book.objects.filter(
# is_deleted=False
# )

# if genre:
# books = books.filter(genres__id=genre)

# if topic:
# books = books.filter(topics__id=topic)

# books = books.order_by('-id')
# paginator = Pagination()
# page = paginator.paginate_queryset(books, request)

# event_logger(
# event='retrieve',
# object='book',
# user=request.user,
# device=request.device,
# ip_address=request.ip_address,
# )

# return paginator.get_paginated_response(
# BookSerializer(page, many=True).data
# )

# def post(self, request, *args, **kwargs):
# self.permission_classes = [IsAdminOrModerator]
# self.check_permissions(request)
# request.data['added_by'] = request.user.id
# serializer = BookSerializer(
# data=request.data,
# )
# serializer.is_valid(raise_exception=True)
# serializer.save()

# return Response(serializer.data, status=201)
Loading