frontend clean code

rkshaon · Sep 11, 2024 · b338559 · b338559
1 parent 31b033c
commit b338559
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 6 deletions.
diff --git a/frontend/.env.production b/frontend/.env.production
@@ -1 +1 @@
-VUE_APP_BACKEND_URL=https://api.production-url.com  # Your production backend URL
+VUE_APP_BACKEND_URL=https://api.production-url.com
diff --git a/frontend/src/components/BookCardComponent.vue b/frontend/src/components/BookCardComponent.vue
@@ -1,10 +1,8 @@
 <template>
   <div class="bg-white shadow-lg rounded-lg overflow-hidden">
-    <!-- <img :src="book.cover_image" alt="Book Cover" class="w-full h-48 object-cover"> -->
     <img :src="getCoverImageUrl(book.cover_image)" alt="Book Cover" class="w-full h-48 object-cover">
     <div class="p-4">
       <h3 class="text-lg font-bold text-gray-800">{{ book.title }}</h3>
-      <!-- <p class="text-gray-600">{{ book.authors.join(', ') }}</p> -->
       <p class="text-gray-600">{{ book.authors.map(author => author.full_name).join(', ') }}</p>
     </div>
   </div>
@@ -21,7 +19,6 @@ export default {
   },
   methods: {
     getCoverImageUrl (coverImage) {
-      // const baseURL = 'http://localhost:8001/'
       const API_BASE_URL = process.env.VUE_APP_BACKEND_URL
       return coverImage ? `${API_BASE_URL}${coverImage}` : 'https://fastly.picsum.photos/id/1/200/300.jpg?hmac=jH5bDkLr6Tgy3oAg5khKCHeunZMHq0ehBZr6vGifPLY' // Fallback to default image if cover_image is null
     }

diff --git a/frontend/src/services/v1/bookAPIService.js b/frontend/src/services/v1/bookAPIService.js
@@ -4,8 +4,6 @@ import axios from 'axios'
 
 const API_BASE_URL = process.env.VUE_APP_BACKEND_URL
 
-console.log('url', API_BASE_URL)
-
 export default {
   async fetchV1Books(url) {
     const finalUrl = url || `${API_BASE_URL}/book/v1/?page_size=8`;
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		VUE_APP_BACKEND_URL=https://api.production-url.com # Your production backend URL
		VUE_APP_BACKEND_URL=https://api.production-url.com