use rbenv-root command instead of env var #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if #2 was an issue prior to rbenv ensuring $RBENV_ROOT exists, but we should rely on the env var as guaranteed by rbenv itself. This avoids an additional shell-call. |
rbenv guarantees that $RBENV_ROOT is set in the environment within which rbenv-update runs. see wiki docs: https://github.com/sstephenson/rbenv/wiki/Authoring-plugins#environment and in source: https://github.com/sstephenson/rbenv/blob/7ad01b2b485fb635d7a96daef33f6a733e5b1c80/libexec/rbenv#L50-L55
jasonkarns
force-pushed
the
rbenv-root-command
branch
from
c4c3fb9 to
23b129e
Compare
|
this also makes #9 moot |
jasonkarns
added a commit
that referenced
this pull request
Mar 30, 2015
use rbenv-root command instead of env var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rbenv guarantees that $RBENV_ROOT exists within the environment in which an rbenv plugin runs. There is no need to shell out to rbenv-root to get that value (all it does is echo $RBENV_ROOT, anyhow).
However,$RBENV_ROOT may not exist when a user is directly installing rbenv-update. So the installation instructions should rely on $ (rbenv root) which will provide the default value if $RBENV_ROOT isn't set by the user.