Merge pull request woocommerce#24385 from woocommerce/fix/24356

Ensure WC_Product_Data_Store_CPT::is_existing_sku() return boolean
rkaiser0324 · Aug 21, 2019 · c3262ee · c3262ee
2 parents 9914ac5 + 5a1615a
commit c3262ee
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/includes/data-stores/class-wc-product-data-store-cpt.php b/includes/data-stores/class-wc-product-data-store-cpt.php
@@ -949,7 +949,7 @@ public function is_existing_sku( $product_id, $sku ) {
 		global $wpdb;
 
 		// phpcs:ignore WordPress.VIP.DirectDatabaseQuery.DirectQuery
-		return $wpdb->get_var(
+		return (bool) $wpdb->get_var(
 			$wpdb->prepare(
 				"
 				SELECT posts.ID
@@ -1088,7 +1088,7 @@ public function find_matching_product_variation( $product, $match_attributes = a
 
 		$query .= ' AND postmeta.meta_key IN ( "' . implode( '","', array_map( 'esc_sql', $meta_attribute_names ) ) . '" )';
 
-		$query.=' ORDER BY posts.menu_order ASC, postmeta.post_id ASC;';
+		$query .= ' ORDER BY posts.menu_order ASC, postmeta.post_id ASC;';
 
 		$attributes = $wpdb->get_results( $query ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared