mplayer missing fullscreen option

[parkerlreed]

Noticed videos not playing in fullscreen.

Checked code and it seems mplayer is missing the -fs option

def play_url_mplayer(url,novideo):

if novideo:
  player = subprocess.Popen(
        ['mplayer', '-quiet', '-novideo', '--', url.decode('UTF-8').strip()$
        stdout = subprocess.PIPE, stderr = subprocess.PIPE)
else:
  player = subprocess.Popen(
        ['mplayer', '-quiet', '', '--', url.decode('UTF-8').strip()],
        stdout = subprocess.PIPE, stderr = subprocess.PIPE)
player.wait()

[hololight]

Wasn't totally an oversight on my part. Should fullscreen be default behavior? Remember that 'f' will toggle while video is playing. I can 'fix' it easy enough if that is what is wanted or even make it another command line flag.

Soon enough I want to move all these options into the UI.

[parkerlreed]

The fullscreen was default before. Thinking about it now, it's actually
nice to not have it launch to fullscreen. Kinda like browsing to the
youtube page. If you are just wanting to view something quickly you don't
bother going fullscreen.

I think that would be good as an extra argument (and eventually in the UI)

On Sun, Jul 14, 2013 at 11:08 AM, hololight notifications@github.comwrote:

Wasn't totally an oversight on my part. Should fullscreen be default
behavior? Remember that 'f' will toggle while video is playing. I can 'fix'
it easy enough if that is what is wanted or even make it another command
line flag.

Soon enough I want to move all these options into the UI.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/16#issuecomment-20937644
.