fix: Removed infinite loop in AltDateWidget #3518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgros
approved these changes
Mar 17, 2023
heath-freenome
force-pushed
the
fix-3516
branch
from
69386a0 to
24d75b2
Compare
Fixes rjsf-team#3516 by removing the infinite loop caused by two `useEffects()` by adding a new state for the `value` and combining the effects into one - Updated `AltDateWidget` to stash the `value` in state and combining the two `useEffects()` into a single effect - The effect will call `onChange()` when the `state` is ready for change AND it causes a different string than the current `value` - If the `lastValue` recorded differs from the `value`, then we record the new `value` and set the `state` to it - Updated the `CHANGELOG.md` accordingly
heath-freenome
force-pushed
the
fix-3516
branch
from
24d75b2 to
77ba693
Compare
nickgros
approved these changes
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes #3516 by removing the infinite loop caused by two
useEffects()by adding a new state for thevalueand combining the effects into oneAltDateWidgetto stash thevaluein state and combining the twouseEffects()into a single effectonChange()when thestateis ready for change AND it causes a different string than the currentvaluelastValuerecorded differs from thevalue, then we record the newvalueand set thestateto itCHANGELOG.mdaccordinglyChecklist
npm run test:updateto update snapshots, if needed.