fix: Add support for custom styles in a manner similar to classNames #3378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
nickgros
requested changes
Jan 15, 2023
There was a problem hiding this comment.
@heath-freenome WDYT about using style to match the React property rather than styles? It seemed like @epicfaace also suggested the same in the original issue and PR.
Code changes otherwise LGTM.
Fixes rjsf-team#1200 by reimplementing rjsf-team#1256 - In `@rjsf/utils`, added the new `style` prop onto `FieldTemplateProps`, `WrapIfAdditionalTemplateProps` and `UIOptionsBaseType` - In `@rjsf/core`, added support for the new `style` prop in `uiSchema` as follows: - Updated `SchemaField` to handle the new `style` prop in the `uiSchema` similarly to `classNames`, passing it to the `FieldTemplate` and removing it from being passed down to children. - Also, added support for new `style` prop on `FieldTemplate` and `WrapIfAdditionalTemplate` rendering them on the outermost wrapper - Added or updated tests to verify the `style` prop functionality - In all the themes, added support for new `style` prop on `FieldTemplate` and `WrapIfAdditionalTemplate` rendering them on the outermost wrapper - Fluent-ui is a special case since it doesn't currently implement `WrapIfAdditionalTemplate` fully - Updated the documentation to describe this new `style` prop - Also updated the `validation` documentation to describe the `uiSchema` prop that can be passed to the `customValidate()` and `transformError()` functions - Updated the `CHANGELOG.md` accordingly
heath-freenome
force-pushed
the
reimplement-1256
branch
from
29b58f9 to
1cb0ef3
Compare
nickgros
approved these changes
Jan 15, 2023
Co-authored-by: Nick Grosenbacher <nickgrosenbacher@gmail.com>
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this pull request
Jun 8, 2023
…jsf-team#3378) * fix: Add support for custom styles in a manner similar to classNames Fixes rjsf-team#1200 by reimplementing rjsf-team#1256 - In `@rjsf/utils`, added the new `style` prop onto `FieldTemplateProps`, `WrapIfAdditionalTemplateProps` and `UIOptionsBaseType` - In `@rjsf/core`, added support for the new `style` prop in `uiSchema` as follows: - Updated `SchemaField` to handle the new `style` prop in the `uiSchema` similarly to `classNames`, passing it to the `FieldTemplate` and removing it from being passed down to children. - Also, added support for new `style` prop on `FieldTemplate` and `WrapIfAdditionalTemplate` rendering them on the outermost wrapper - Added or updated tests to verify the `style` prop functionality - In all the themes, added support for new `style` prop on `FieldTemplate` and `WrapIfAdditionalTemplate` rendering them on the outermost wrapper - Fluent-ui is a special case since it doesn't currently implement `WrapIfAdditionalTemplate` fully - Updated the documentation to describe this new `style` prop - Also updated the `validation` documentation to describe the `uiSchema` prop that can be passed to the `customValidate()` and `transformError()` functions - Updated the `CHANGELOG.md` accordingly * - Renamed `styles` to `style` * Apply suggestions from code review Co-authored-by: Nick Grosenbacher <nickgrosenbacher@gmail.com> Co-authored-by: Nick Grosenbacher <nickgrosenbacher@gmail.com>
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this pull request
Jun 8, 2023
…jsf-team#3378) * fix: Add support for custom styles in a manner similar to classNames Fixes rjsf-team#1200 by reimplementing rjsf-team#1256 - In `@rjsf/utils`, added the new `style` prop onto `FieldTemplateProps`, `WrapIfAdditionalTemplateProps` and `UIOptionsBaseType` - In `@rjsf/core`, added support for the new `style` prop in `uiSchema` as follows: - Updated `SchemaField` to handle the new `style` prop in the `uiSchema` similarly to `classNames`, passing it to the `FieldTemplate` and removing it from being passed down to children. - Also, added support for new `style` prop on `FieldTemplate` and `WrapIfAdditionalTemplate` rendering them on the outermost wrapper - Added or updated tests to verify the `style` prop functionality - In all the themes, added support for new `style` prop on `FieldTemplate` and `WrapIfAdditionalTemplate` rendering them on the outermost wrapper - Fluent-ui is a special case since it doesn't currently implement `WrapIfAdditionalTemplate` fully - Updated the documentation to describe this new `style` prop - Also updated the `validation` documentation to describe the `uiSchema` prop that can be passed to the `customValidate()` and `transformError()` functions - Updated the `CHANGELOG.md` accordingly * - Renamed `styles` to `style` * Apply suggestions from code review Co-authored-by: Nick Grosenbacher <nickgrosenbacher@gmail.com> Co-authored-by: Nick Grosenbacher <nickgrosenbacher@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes #1200 by reimplementing #1256
@rjsf/utils, added the newstyleprop ontoFieldTemplateProps,WrapIfAdditionalTemplatePropsandUIOptionsBaseType@rjsf/core, added support for the newstyleprop inuiSchemaas follows:SchemaFieldto handle the newstyleprop in theuiSchemasimilarly toclassNames, passing it to theFieldTemplateand removing it from being passed down to children.styleprop onFieldTemplateandWrapIfAdditionalTemplaterendering them on the outermost wrapperstyleprop functionalitystyleprop onFieldTemplateandWrapIfAdditionalTemplaterendering them on the outermost wrapperWrapIfAdditionalTemplatefullystylepropvalidationdocumentation to describe theuiSchemaprop that can be passed to thecustomValidate()andtransformError()functionsCHANGELOG.mdaccordinglyChecklist
npm run test:updateto update snapshots, if needed.