Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support error list to show at the top or bottom #3196

Merged
merged 14 commits into from
Oct 26, 2022
Merged

feat: support error list to show at the top or bottom #3196

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2bc3167
feat: support error list to show at the top or bottom
jacqueswho Oct 12, 2022
a1dfc6f
chore: required changes
jacqueswho Oct 17, 2022
930cb60
chore
jacqueswho Oct 17, 2022
28af07e
Apply suggestions from code review
heath-freenome Oct 17, 2022
ac41f09
Update CHANGELOG.md
jacqueswho Oct 18, 2022
c27400e
chore: added test
jacqueswho Oct 18, 2022
13c9b3a
Merge branch '634-support-showing-the-error-list-at-the-bottom-of-the…
jacqueswho Oct 18, 2022
bf070b8
Merge branch 'main' into 634-support-showing-the-error-list-at-the-bo…
jacqueswho Oct 18, 2022
f18c77a
chore
jacqueswho Oct 18, 2022
4916d7f
Merge branch '634-support-showing-the-error-list-at-the-bottom-of-the…
jacqueswho Oct 18, 2022
e5c6b1b
chore
jacqueswho Oct 18, 2022
ee93d04
chore
jacqueswho Oct 18, 2022
479b475
chore: cleanup
jacqueswho Oct 25, 2022
0a02583
Merge branch 'main' into 634-support-showing-the-error-list-at-the-bo…
jacqueswho Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: cleanup
  • Loading branch information
@jacqueswho
jacqueswho committed Oct 25, 2022
commit 479b475ff884cc68666e657b0efec07a7653eb02
2 changes: 1 addition & 1 deletion .node-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16
16.0.0
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ should change the heading of the (upcoming) version to include a major version b

## @rjsf/chakra-ui
- Automatically close single-choice Select widget on selection

## @rjsf/core
- BREAKING CHANGE: ShowErrorList prop changed to support `false`, `top` or `bottom`; `true` is no longer a valid value as the default changed from `true` to `top` [#634](https://github.com/rjsf-team/react-jsonschema-form/issues/634)
- Added the new generic, `S extends StrictRJSFSchema = RJSFSchema`, for `schema`/`rootSchema` to every component that needed it.
Expand Down Expand Up @@ -56,13 +57,15 @@ should change the heading of the (upcoming) version to include a major version b
- In `SelectWidget` multiple-choice select display label rather than value for selected items
- Updated `ArrayFieldTemplate` to always render `ArrayFieldDescriptionTemplate` since that template deals with the optional `description`
- Pass the `schema` into the `ArrayFieldDescriptionTemplate`, `ArrayFieldTitleTemplate`, `DescriptionFieldTemplate` and `TitleFieldTemplate`, fixing [#3176](https://github.com/rjsf-team/react-jsonschema-form/issues/3176)

## @rjsf/core
- Extended `Form.onChange` to optionally return the `id` of the field that caused the change, fixing [#2768](https://github.com/rjsf-team/react-jsonschema-form/issues/2768)
- Fixed a regression in earlier v5 beta versions where additional properties could not be added when `additionalProperties` was `true` ([#3719](https://github.com/rjsf-team/react-jsonschema-form/pull/3719)).
- Fixed a regression in v5 beta version where BooleanField was altering readonly props ([#3188](https://github.com/rjsf-team/react-jsonschema-form/pull/3188).
- Updated `ArrayFieldDescriptionTemplate` and `ArrayFieldTitleTemplate` to not render content when `ui:label` is false, fixing [#2535](https://github.com/rjsf-team/react-jsonschema-form/issues/2535)
- Updated `ArrayFieldTemplate` to always render `ArrayFieldDescriptionTemplate` since that template deals with the optional `description`
- Pass the `schema` into the `ArrayFieldDescriptionTemplate`, `ArrayFieldTitleTemplate`, `DescriptionFieldTemplate` and `TitleFieldTemplate`, fixing [#3176](https://github.com/rjsf-team/react-jsonschema-form/issues/3176)

## @rjsf/fluent-ui
- Updated `ArrayFieldTemplate` to always render `ArrayFieldDescriptionTemplate` since that template deals with the optional `description`
- Pass the `schema` into the `ArrayFieldDescriptionTemplate`, `ArrayFieldTitleTemplate`, `DescriptionFieldTemplate` and `TitleFieldTemplate`, fixing [#3176](https://github.com/rjsf-team/react-jsonschema-form/issues/3176)
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/components/Form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,8 +427,8 @@ export default class Form<
renderErrors(registry: Registry<T, S, F>) {
const { errors, errorSchema, schema, uiSchema } = this.state;
const { formContext } = this.props;
const options = getUiOptions<T, F>(uiSchema);
const ErrorListTemplate = getTemplate<"ErrorListTemplate", T, F>(
const options = getUiOptions<T, S, F>(uiSchema);
const ErrorListTemplate = getTemplate<"ErrorListTemplate", T, S, F>(
"ErrorListTemplate",
registry,
options
Expand Down