Add uiSchema to BooleanField widget

[henriksvensson]

Fixes issue #2549.

[epicfaace]

Looks good! Can you add a quick test to ensure this doesn't regress in the future?

[jorisw]

Could we just merge this? RJSF was broken to begin with in regards to this PR, and I don't see any other tests in core that test for the passing of the uiSchema prop to custom widgets.

[jorisw]

@henriksvensson I've written this test, could you add it? Feel free to improve it if you want.

  // packages/core/test/BooleanField_test.js

  it("should pass uiSchema to custom Boolean widget", () => {
    const CustomCheckboxWidget = ({ uiSchema }) => {
      return <div id="custom-ui-option-value">{uiSchema.custom_widget_key['ui:options'].test}</div>;
    };

    const { node } = createFormComponent({
      schema: {
        type: "boolean",
        description: "my description",
      },
      widgets: {
        CheckboxWidget: CustomCheckboxWidget
      },
      uiSchema: {
        custom_widget_key: {
          'ui:widget': 'checkbox',
          'ui:options': {
            'test': 'foo'
          }
        }
      }
    });

    expect(node.querySelector("#custom-ui-option-value").textContent).to.eql("foo");
  });

Please also merge master so we can get this PR approved.

[epicfaace]

Feel free to make a new PR based on this one with this test! Thanks for writing it.

…

-- Ashwin Ramaswami

On Wed, Oct 20, 2021 at 5:00 AM Joris W ***@***.***> wrote: @henriksvensson <https://github.com/henriksvensson> I've written this test, could you add it? Feel free to improve it if you want. it("should pass uiSchema to custom wigdet", () => { const CustomCheckboxWidget = ({ uiSchema }) => { return <div id="custom-ui-option-value">{uiSchema.custom_field_key['ui:options'].test}</div>; }; const { node } = createFormComponent({ schema: { type: "boolean", description: "my description", }, widgets: { CheckboxWidget: CustomCheckboxWidget }, uiSchema: { custom_field_key: { 'ui:widget': 'checkbox', 'ui:options': { 'test': 'foo' } } } }); expect(node.querySelector("#custom-ui-option-value").textContent).to.eql("foo"); }); — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2550 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAM4MXY6E3ZAFTTX2X5EVQDUH2AKNANCNFSM5EEQFNMQ> .

[epicfaace]

Closing in favor of #2587

[henriksvensson]

Thanks for solving this, @jorisw!