Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript webpack setup #1446

Closed
wants to merge 7 commits into from
Closed

Typescript webpack setup #1446

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
88ee167
set up typescript
epicfaace Sep 4, 2019
09f46da
Move form file to typescript
epicfaace Sep 4, 2019
b223363
fix tests by adding valid extensions to @babel/register config
epicfaace Sep 4, 2019
88399f8
Fix @babel/register dependency
epicfaace Sep 4, 2019
d7133fa
fix extensions for dist build
epicfaace Sep 4, 2019
9de7a44
Rename from js -> tsx
epicfaace Sep 11, 2019
586f083
fix docs
epicfaace Sep 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move form file to typescript
  • Loading branch information
@epicfaace
epicfaace committed Sep 4, 2019
commit 09f46da969438fe78ac6a638737f994241754f7a
7 changes: 6 additions & 1 deletion src/components/Form.js → src/components/Form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,12 @@ import {
} from "../utils";
import validateFormData, { toErrorList } from "../validate";

export default class Form extends Component {
interface IFormProps {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has there been any discussion to export typings with the build or will you maintain typings within @types/react-jsonschema-form?

To add onto that, has there been any discussion regarding naming conventions for types?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet. It would be great to start one!

What would be the advantages/disadvantages of exporting typings with the build vs maintaining typings within @types/react-jsonschema-form? Do other libraries based in typescript typically do the former?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the advantages/disadvantages of exporting typings with the build vs maintaining typings within @types/react-jsonschema-form?

A big drawback with using DefinitelyTyped is that it's community maintained and can sometimes get out of sync with the actual library. That repository is mainly for JS packages that don't have typings for TS projects. And sometimes DefinitelyTyped can take a while to merge PR's so you'd have to wait for a release before you could use new typings.

With that in mind, it's usually better to export typings with the package so your types are always 1:1 and you don't have to maintain two separate packages.

Do other libraries based in typescript typically do the former?

Usually yeah. Check out nestjs or even vscode. Go explore some more TS packages here in GH

[x: string]: any,
formElement: any
}

export default class Form extends Component<IFormProps, any> {
static defaultProps = {
uiSchema: {},
noValidate: false,
Expand Down