Bump webpack #1040
Merged
Bump webpack #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
module.loaders is now module.rules. https://webpack.js.org/migrate/3/#module-loaders-is-now-module-rules Chaining loaders is no longer done using !. We only do this in one place (style!css). https://webpack.js.org/migrate/3/#chaining-loaders It's no longer allowed to omit -loader. https://webpack.js.org/migrate/3/#automatic-loader-module-name-extension-removed We no longer need json-loader. https://webpack.js.org/migrate/3/#json-loader-is-not-required-anymore
The documentation seems to say this is the default during prod, but I haven't been able to make it emit any bad assets in dev either.
|
Ok, time for Babel 7? |
|
Yeah, why not? Have to keep up with the ecosystem, right? |
althalus86
added a commit
to althalus86/react-jsonschema-form
that referenced
this pull request
Nov 3, 2018
This reverts commit b6ae4f4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Current webpack is v4.20.0. Our version was still v1...
I figured once I had #1039 closed, I would try to clean this up. @graingert , what do you think?
Checklist
npm run cs-formaton my branch to conform my code to prettier coding style