-
Notifications
You must be signed in to change notification settings - Fork 3
Remove forced lf in .editorconfig #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe changes in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Code Climate has analyzed commit a09b310 and detected 0 issues on this pull request. View more on Code Climate. |
#215 added the new
.gitattributes
from .NET, which does git normalization and lets IDEs use the OS default. This avoids a bunch of eol churn because some tools respect.editorconfig
and some do not. However, I forgot to remove the forced lf in .editorconfig which meant we still got eol churn caused by tools that did respect .editorconfig.This change removes eol settings from .editorconfig and should (finally) fix eol churn.