Skip to content

Conversation

rjmurillo
Copy link
Owner

@rjmurillo rjmurillo commented Jun 24, 2024

Code clean up. Remove most instances of AV1535

Changes

  • Remove cases where a type was marked as nullable when it wasn't actually nullable
  • Convert Helpers class to various extension methods
  • Add code comments to aid in clarity for future maintainers
  • Remove suppressions for AV1535

@rjmurillo rjmurillo linked an issue Jun 24, 2024 that may be closed by this pull request
4 tasks
@rjmurillo rjmurillo added the .NET Pull requests that update .net code label Jun 24, 2024
Copy link

codacy-production bot commented Jun 24, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.37% (target: -1.00%) 93.75% (target: 95.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ba89475) 406 378 93.10%
Head commit (11c4c4b) 413 (+7) 383 (+5) 92.74% (-0.37%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#113) 80 75 93.75%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@rjmurillo rjmurillo requested a review from MattKotsenas June 24, 2024 17:15
@rjmurillo rjmurillo added this to the vNext milestone Jun 24, 2024
@rjmurillo rjmurillo marked this pull request as ready for review June 24, 2024 17:15
@rjmurillo rjmurillo enabled auto-merge (squash) June 24, 2024 17:15
@rjmurillo rjmurillo merged commit b911035 into main Jun 24, 2024
@rjmurillo rjmurillo deleted the 90-refactor-code-to-remove-analyzer-warnings branch June 24, 2024 18:47
@github-actions github-actions bot added the analyzers Change that impacts an analyzer behavior label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzers Change that impacts an analyzer behavior .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor code to remove analyzer warnings
2 participants