proposed fix for failing tests in MasterRegistrationTest. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jubeira, this might be what we were looking for. I went ahead and merged the previous PR that you reviewed and aproved so I don't understand why that commit is appearing as a change in this PR? Also I'm pretty sure that there's a better way of handling the caught exception in the last commit. I'll make sure to fix that after your review and squash if necessary. |
rjcausarano
force-pushed
the
master-registration-tests
branch
2 times, most recently
from
41ef4ee to
16b075d
Compare
|
Alright this last commit does the following:
|
jubeira
requested changes
Apr 9, 2019
There was a problem hiding this comment.
Great job, thanks @rjcausarano!
I've left a couple of minor comments; please address them and squash everything into one commit before sending the PR upstream.
rosjava/src/main/java/org/ros/internal/node/topic/DefaultPublisher.java
Outdated
Show resolved
Hide resolved
rosjava/src/main/java/org/ros/internal/node/topic/DefaultPublisher.java
Outdated
Show resolved
Hide resolved
…signals to be delivered before shutting down listeners. Creates new testUnregisterPublisherFailure() test in class MasterRegistrationTest.
rjcausarano
force-pushed
the
master-registration-tests
branch
from
16b075d to
1a3fbd2
Compare
jubeira
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waits for all signals to be delivered before shutting down listeners in class DefaultPublisher.