Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabulator in DarkMode #540

Closed
may-day opened this issue Oct 5, 2024 · 5 comments
Closed

Tabulator in DarkMode #540

may-day opened this issue Oct 5, 2024 · 5 comments
Assignees

Comments

@may-day
Copy link

may-day commented Oct 5, 2024

In KVision 8.0 dark mode the tabulator cell background stays the same as in light mode. Bug or am i missing something?
Light mode:
grafik

Dark mode:
grafik

@rjaros
Copy link
Owner

rjaros commented Oct 5, 2024

It should work. Check the showcase example (light/dark mode switch is at the bottom):
https://rjaros.github.io/kvision-examples/showcase/#/tabulator

@rjaros
Copy link
Owner

rjaros commented Oct 5, 2024

Please check your modules initializers list (especially check if you have CoreModule at the end):
https://github.com/rjaros/kvision-examples/blob/master/showcase/src/jsMain/kotlin/com/example/Showcase.kt#L117-L133

@may-day
Copy link
Author

may-day commented Oct 5, 2024

Turns out it only works if TableType.BORDERED is one of the types in tabulator.

@rjaros
Copy link
Owner

rjaros commented Oct 5, 2024

So it's a bug, thanks for reporting.

@rjaros rjaros self-assigned this Oct 5, 2024
@rjaros
Copy link
Owner

rjaros commented Oct 16, 2024

Fixed in 8.0.1

@rjaros rjaros closed this as completed Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants