Update Call.js #47
Merged
Update Call.js #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can choose whether to pass the callId or create it as usual. This is to facilitate calls with an external service while keeping the same callId. In onCallStateChange I pass the callId to better manage multicalls.
Modified destroy method. First break the interval and then destroy
|
Modified destroy method. First break the interval and then destroy |
if audio is not valued I force it to true. This is to avoid errors on devices like Oppo, when the app is killed and receives the call
Restore previous modification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can choose whether to pass the callId or create it as usual. This is to facilitate calls with an external service while keeping the same callId. In onCallStateChange I pass the callId to better manage multicalls.