-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Add timeout option to open() to kill time-consuming cmd() calls #47
Conversation
80fb6c0
to
6b9b5eb
Compare
Nice! it makes sense to have a timeout on the command, but is not clear the time unit. can you rename it as |
6b9b5eb
to
b88d8d2
Compare
b88d8d2
to
82f63a9
Compare
can you also bump the version? so we can just upload a new version to pip |
I bumped it to 0.5.0 since we added a feature, let me know if you want to change it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^
5b0c0ae
to
10e5d25
Compare
Proposed changes to fix #46
Usage:
When the timeout is triggered it will throw an exception:
By default, it won't enable timeout to be backward compatible