-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RzIL implementation of MIPS32 ops #4882
Conversation
I am thinking to add a sha1 emulateme binary which will add more operations to check the correctness of the execution |
Could you please provide a coverage? How many instructions are implemented and how many - aren't? Floating point aside, I see there are many still aren't implemented, judging by the source code. Or at least explain what is implemented and what currently isn't in the PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just those little things.
Please run the asm tests with ASAN and the leak sanitizer, if not done yet.
Already done. no changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once you address @Rot127 feedback.
Implements most of the normal MIPS32 isa from MD00086 Rev 5.04 Does not implement MIPS64, FP, COP2 and HW operations.
Your checklist for this pull request
RZ_API
function and struct this PR changes.RZ_API
).Detailed description
Adds RzIL uplifting for capstone mips.
75
common ops from MIPS32 spec7
common ops from MIPS64 spec (lwu, ld, dadd, etc...)35
special ops (interrupts, cache sync, cache prefetch, TLB, breakpoints, traps, etc..) asNOP
58
floating point ops from MIPS32 spec (will be done in another PR)20
Hardware ops (syscall, interrupt return, etc..) from MIPS32 spec (will be done in another PR)Test plan
Add emulateme binaries.