-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/supported cpu #4861
Merged
notxvilka
merged 5 commits into
rizinorg:dev
from
well-mannered-goat:feature/supported-cpu
Jan 25, 2025
Merged
Feature/supported cpu #4861
notxvilka
merged 5 commits into
rizinorg:dev
from
well-mannered-goat:feature/supported-cpu
Jan 25, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notxvilka
requested changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, please also update the man page for rz-asm
.
notxvilka
requested changes
Jan 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one minor pick
have created a pull request to update in the rizin book too |
notxvilka
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
RZ_API
function and struct this PR changes.RZ_API
).Detailed description
I have added on option (-m) for the command rz-asm. It expects and argument which would be the plugin whose supported the user wants to see.
If no cpu is supported for that plugin, nothing will be printed.
Test plan
rz-asm -m mips
rz-asm -m xtensa
rz-asm -m sparc
Closing issues
closes #4805