Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/supported cpu #4861

Merged
merged 5 commits into from
Jan 25, 2025
Merged

Conversation

well-mannered-goat
Copy link
Contributor

@well-mannered-goat well-mannered-goat commented Jan 24, 2025

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository.
  • I made sure to follow the project's coding style.
  • I've documented every RZ_API function and struct this PR changes.
  • I've added tests that prove my changes are effective (required for changes to RZ_API).
  • I've updated the Rizin book with the relevant information (if needed).

Detailed description

I have added on option (-m) for the command rz-asm. It expects and argument which would be the plugin whose supported the user wants to see.
If no cpu is supported for that plugin, nothing will be printed.

Test plan

rz-asm -m mips
rz-asm -m xtensa
rz-asm -m sparc

Closing issues

closes #4805

Copy link

@notxvilka notxvilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, please also update the man page for rz-asm.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 25, 2025
Copy link

@notxvilka notxvilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor pick

librz/main/rz-asm.c Outdated Show resolved Hide resolved
@well-mannered-goat
Copy link
Contributor Author

have created a pull request to update in the rizin book too

@notxvilka notxvilka merged commit 3520054 into rizinorg:dev Jan 25, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation rz-asm rz-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listing supported CPUs in rz-asm -L and La
2 participants