Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused rz_big #3553

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Remove unused rz_big #3553

wants to merge 1 commit into from

Conversation

wargio
Copy link
Member

@wargio wargio commented Jun 4, 2023

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Its is unused and slims down the libs

Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, it might be useful for the big numbers in rz-ax, as well as in RzIL

@XVilka
Copy link
Member

XVilka commented Jun 4, 2023

See, e.g. #3331

@wargio
Copy link
Member Author

wargio commented Jun 4, 2023

Wait, it might be useful for the big numbers in rz-ax, as well as in RzIL

i don't see the need for this. BitVec is enough also for rz-ax.
Besides, is not used anywhere, besides on the unit test

@XVilka
Copy link
Member

XVilka commented Jun 4, 2023

Performing big number arithmetic by converting to bitvectors back and forth where there is no need for them will be very slow. Please pause this PR, we need better discussion about it

@wargio wargio marked this pull request as draft June 4, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants