Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RzIODescData magic checks (Fix #2696) #2698

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Fix RzIODescData magic checks (Fix #2696) #2698

merged 1 commit into from
Jun 14, 2022

Conversation

thestr4ng3r
Copy link
Member

@thestr4ng3r thestr4ng3r commented Jun 14, 2022

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Fix a regression from 7672170:
The native macOS debugger was broken because of the full 64bit hash
being compared to a truncated version of itself.
This magic is probably entirely superfluous, but we first restore the
functionality as it was before.

Test plan

On macOS, rz -d <some executable> should show some code/data of the process.

Fix #2696

Fix a regression from 7672170:
The native macOS debugger was broken because of the full 64bit hash
being compared to a truncated version of itself.
This magic is probably entirely superfluous, but we first restore the
functionality as it was before.
@github-actions github-actions bot added the API label Jun 14, 2022
@thestr4ng3r thestr4ng3r added this to the 0.4.0 milestone Jun 14, 2022
@thestr4ng3r thestr4ng3r changed the title Fix RzIODescData magic checks Fix RzIODescData magic checks (Fix #2696) Jun 14, 2022
@XVilka XVilka merged commit 3dfc4b1 into dev Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugging is broken on MacOS x86 and ARMv8, Linux ARMv8
2 participants