Skip to content

feat: modernize library#33

Merged
rezigned merged 5 commits intorize:masterfrom
shyim:modernize-package
Sep 9, 2024
Merged

feat: modernize library#33
rezigned merged 5 commits intorize:masterfrom
shyim:modernize-package

Conversation

@shyim
Copy link
Contributor

@shyim shyim commented Aug 30, 2024

No description provided.

@shyim shyim force-pushed the modernize-package branch from b05eeb1 to 8773e0e Compare September 3, 2024 06:58
@shyim shyim marked this pull request as ready for review September 3, 2024 07:10
@shyim
Copy link
Contributor Author

shyim commented Sep 3, 2024

@rezigned This is ready 😅

->setFinder(
(new Finder())
->in([__DIR__ . '/src', __DIR__ . '/tests'])
); No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline at the end.

level: 5
paths:
- src
- tests No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Copy link
Member

@rezigned rezigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All goods and thank you for the help! 👍 (now the question is how should we version this 😅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants