Skip to content

Commit

Permalink
Remove support for webhook from csi-addons
Browse files Browse the repository at this point in the history
As webhooks are complicated and hard to maintain
removing it from the repo and will use CEL for
all the required validations.

print deprecated log for webhook

as webhook is disabled and print
a log if its enabled.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
  • Loading branch information
Madhu-1 authored and mergify[bot] committed Sep 28, 2023
1 parent bde2c67 commit d9c253e
Show file tree
Hide file tree
Showing 28 changed files with 40 additions and 2,761 deletions.
4 changes: 0 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,6 @@ manifests: controller-gen kustomize ## Generate WebhookConfiguration, ClusterRol
$(KUSTOMIZE) build config/crd > deploy/controller/crds.yaml
$(KUSTOMIZE) build config/rbac > deploy/controller/rbac.yaml
$(KUSTOMIZE) build config/manager > deploy/controller/setup-controller.yaml
# Disable admission webhooks by default in setup-controller as it need setting up cert managager
sed -i 's|enable-admission-webhooks=true|enable-admission-webhooks=false|g' deploy/controller/setup-controller.yaml
# generate single yaml which includes crds, rbac, controller, webhooks, certificates
$(KUSTOMIZE) build config/default > deploy/controller/install-all-in-one.yaml

# generate the <package-name>.clusterserviceversion.yaml base
gen-csv-base:
Expand Down
18 changes: 0 additions & 18 deletions PROJECT
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ resources:
kind: CSIAddonsNode
path: github.com/csi-addons/kubernetes-csi-addons/apis/csiaddons/v1alpha1
version: v1alpha1
webhooks:
validation: true
webhookVersion: v1
- api:
crdVersion: v1
namespaced: true
Expand All @@ -26,9 +23,6 @@ resources:
kind: ReclaimSpaceJob
path: github.com/csi-addons/kubernetes-csi-addons/apis/csiaddons/v1alpha1
version: v1alpha1
webhooks:
validation: true
webhookVersion: v1
- api:
crdVersion: v1
controller: true
Expand All @@ -37,18 +31,12 @@ resources:
kind: NetworkFence
path: github.com/csi-addons/kubernetes-csi-addons/apis/csiaddons/v1alpha1
version: v1alpha1
webhooks:
validation: true
webhookVersion: v1
- controller: true
domain: openshift.io
group: csiaddons
kind: ReclaimSpaceCronJob
path: github.com/csi-addons/kubernetes-csi-addons/apis/csiaddons/v1alpha1
version: v1alpha1
webhooks:
validation: true
webhookVersion: v1
- controller: true
group: core
kind: PersistentVolumeClaim
Expand All @@ -62,9 +50,6 @@ resources:
kind: VolumeReplication
path: github.com/csi-addons/kubernetes-csi-addons/apis/replication.storage/v1alpha1
version: v1alpha1
webhooks:
validation: true
webhookVersion: v1
- api:
crdVersion: v1
namespaced: true
Expand All @@ -73,7 +58,4 @@ resources:
kind: VolumeReplicationClass
path: github.com/csi-addons/kubernetes-csi-addons/apis/replication.storage/v1alpha1
version: v1alpha1
webhooks:
validation: true
webhookVersion: v1
version: "3"
81 changes: 0 additions & 81 deletions apis/csiaddons/v1alpha1/csiaddonsnode_webhook.go

This file was deleted.

89 changes: 0 additions & 89 deletions apis/csiaddons/v1alpha1/networkfence_webhook.go

This file was deleted.

76 changes: 0 additions & 76 deletions apis/csiaddons/v1alpha1/reclaimspacecronjob_webhook.go

This file was deleted.

77 changes: 0 additions & 77 deletions apis/csiaddons/v1alpha1/reclaimspacejob_webhook.go

This file was deleted.

Loading

0 comments on commit d9c253e

Please sign in to comment.