update to proper message on a successful fence op

Signed-off-by: rakeshgm <rakeshgm@redhat.com>
riya-singhal31 · Nov 17, 2023 · 209424e · 209424e
1 parent 699848f
commit 209424e
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/apis/csiaddons/v1alpha1/networkfence_types.go b/apis/csiaddons/v1alpha1/networkfence_types.go
@@ -40,6 +40,14 @@ const (
 	FencingOperationResultFailed FencingOperationResult = "Failed"
 )
 
+const (
+	// FenceOperationSuccessfulMessage represents successful message on fence operation
+	FenceOperationSuccessfulMessage = "fencing operation successful"
+
+	// UnFenceOperationSuccessfulMessage represents successful message on unfence operation
+	UnFenceOperationSuccessfulMessage = "unfencing operation successful"
+)
+
 // +kubebuilder:validation:XValidation:rule="self == oldSelf",message="secret is immutable"
 // SecretSpec defines the secrets to be used for the network fencing operation.
 type SecretSpec struct {

diff --git a/controllers/csiaddons/networkfence_controller.go b/controllers/csiaddons/networkfence_controller.go
@@ -154,7 +154,15 @@ func (r *NetworkFenceReconciler) Reconcile(ctx context.Context, req ctrl.Request
 		return ctrl.Result{}, err
 	}
 
-	err = nf.updateStatus(ctx, csiaddonsv1alpha1.FencingOperationResultSucceeded, "fencing operation successful")
+	var successMsg string
+	switch nf.instance.Spec.FenceState {
+	case csiaddonsv1alpha1.Fenced:
+		successMsg = csiaddonsv1alpha1.FenceOperationSuccessfulMessage
+	case csiaddonsv1alpha1.Unfenced:
+		successMsg = csiaddonsv1alpha1.UnFenceOperationSuccessfulMessage
+	}
+
+	err = nf.updateStatus(ctx, csiaddonsv1alpha1.FencingOperationResultSucceeded, successMsg)
 	if err != nil {
 		logger.Error(err, "failed to update status")
 		return ctrl.Result{}, err