Fix ftp module import and small changes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
RemieJanssen
commented
Jun 12, 2023
RemieJanssen
commented
- full path for module import in ftp module
- added CHANGELOG
- added kwargs for mkdir method in filesys classes
- added deletefile method for fs_local class
added 7 commits
June 9, 2023 12:08
| @@ -152,7 +152,7 @@ def lsfilenames(self, path): | |||
| result.append(entry.filename) | |||
| return result | |||
|
|
|||
| def mkdir(self, path): | |||
| def mkdir(self, path, parents=False): | |||
| self.smb_conn.createDirectory(self.share, uxtowin(path)) | |||
There was a problem hiding this comment.
Can we make this adhere to the parents parameter?
There was a problem hiding this comment.
should be simple, I copied the implementation of the irods fs. It uses the folderexists method of the respective fs class. Note: this method uses self.exists(path) for the smb fs, but this exists method does not seem to be implemented.
erwinvanwieringen
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.