Add option to calculate settling velocities for differently shaped particles #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadimsaadi
reviewed
Sep 11, 2025
...opment/20250826_Plastics_Shape_update_files/figure-gfm/Plot the differences between ks-3.png
Show resolved
Hide resolved
Updated the files and knitted the .md file. Should be good now.
Wrote some code to compare the k values for original and bagheri method, and sphere vs fiber. Knitted the md file
|
@nadimsaadi I checked the code updates, thanks for taking the effort. Mainly changed a lot in the documentation of the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
vignettes/3.2-Particle-characteristics.md (https://github.com/rivm-syso/SBooScripts/blob/05c8b25a530d31693d472076cd2f3d882a565ee7/vignettes/3.2-Particle-characteristics.md)
Please when you have time @nadimsaadi add some more description on the approach used to calculate the Settling Velocity in the above vignette.
and
vignettes/Development/20250826_Plastics_Shape_update.md
https://github.com/rivm-syso/SBooScripts/blob/05c8b25a530d31693d472076cd2f3d882a565ee7/vignettes/Development/20250826_Plastics_Shape_update.md