fix: download binaries from R2 before npm publish#40
Merged
NathanFlurry merged 1 commit intomainfrom Jan 30, 2026
Merged
Conversation
This was referenced Jan 30, 2026
Member
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
3 tasks
Member
Author
Merge activity
|
NathanFlurry
force-pushed
the
fix/r2-binary-download
branch
from
f2ab924 to
f73d884
Compare
NathanFlurry
force-pushed
the
docs/quickstart-simplify
branch
from
b13b5d7 to
9162192
Compare
NathanFlurry
changed the base branch from
docs/quickstart-simplify
to
graphite-base/40
The npm CLI platform packages were being published without binaries because publishNpmCli() wasn't downloading them from R2 first. - Add downloadFromReleases() helper to utils.ts - Update publishNpmCli() to download platform binaries before publish - Add sdks/cli/platforms/*/bin/ to .gitignore
NathanFlurry
force-pushed
the
fix/r2-binary-download
branch
from
f73d884 to
acc112d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The npm CLI platform packages were being published without binaries
because publishNpmCli() wasn't downloading them from R2 first.