This repository was archived by the owner on Oct 22, 2025. It is now read-only.
fix: update websocket import logic #646
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in this discussion #621, you get following error when initializing Client on browser environment
This most likely happens because on the websocket.ts file we first try to import ws dynamically, if that is successful we never reach the catch block. For some reason importing ws on the browser environment does not throw even though the
wspackage is not designed to be used on browser.In this PR I flipped the logic other way around, if typeof Websocket is not defined, browser Websocket implementation is used. If Websocket does not exist we try to import
ws.Let me know if this makes sense or not?