-
Notifications
You must be signed in to change notification settings - Fork 147
chore: fix /api routing for dev with new examples #3968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 01-17-feat_examples_better_vercel_support
Are you sure you want to change the base?
chore: fix /api routing for dev with new examples #3968
Conversation
|
🚅 Deployed to the rivet-pr-3968 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Pull Request ReviewThis PR makes a small but important fix to the hello-world example's API routing configuration for development environments. SummaryThe changes add serverless basePath configuration to the actor registry setup and clean up the index.ts file by removing commented code and unnecessary whitespace. Code Quality
Observations
DependenciesThe vite-plugin-srvx dependency update from @312eeb8 to @7 appears to be a version alignment. This looks fine, though the PR title doesn't mention this dependency update. TestingNo tests are modified, which is expected for example code. Manual testing should verify that the /rivet/* routes work correctly in dev mode and that the basePath configuration properly aligns with the Hono route pattern. Security and PerformanceNo security or performance concerns identified. Suggestions
VerdictThe changes are solid and straightforward. The code quality is good, and the cleanup improves readability. Approved with minor suggestions for consideration. |
More templates
@rivetkit/cloudflare-workers
@rivetkit/db
@rivetkit/framework-base
@rivetkit/next-js
@rivetkit/react
rivetkit
@rivetkit/sql-loader
@rivetkit/virtual-websocket
@rivetkit/engine-runner
@rivetkit/engine-runner-protocol
commit: |

No description provided.