Test against all supported versions of Ruby #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flesh out the matrix of versions of Ruby that we test the gem against, adding all three versions that are currently considered to be in maintenance (3.1, 3.2, 3.3) [1]. The setup-ruby step requires a version be specified, so we have a slightly awkward situation here were non-spec jobs use a default `RUBY_VERSION` from env, while the spec job gets a matrix containing more than one version. I've added comments to `RUBY_VERSION` and the matrix to hopefully suggest to anyone making a modification that changing one of them probably means you want to update the other too. [1] https://www.ruby-lang.org/en/downloads/branches/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flesh out the matrix of versions of Ruby that we test the gem against,
adding all three versions that are currently considered to be in
maintenance (3.1, 3.2, 3.3) [1].
The setup-ruby step requires a version be specified, so we have a
slightly awkward situation here were non-spec jobs use a default
RUBY_VERSIONfrom env, while the spec job gets a matrix containingmore than one version. I've added comments to
RUBY_VERSIONand thematrix to hopefully suggest to anyone making a modification that
changing one of them probably means you want to update the other too.
[1] https://www.ruby-lang.org/en/downloads/branches/