Add panictoerror middleware that recovers panics and returns them as errors
#32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
force-pushed
the
brandur-panictoerror
branch
3 times, most recently
from
0a14a8d to
abef583
Compare
Contributor
Author
|
@bgentry Ugh, the build failures here are related to some fixes I have up in a couple other PRs, but should be roughly working. Thoughts? |
brandur
force-pushed
the
brandur-panictoerror
branch
3 times, most recently
from
15d84a0 to
17972e6
Compare
…s errors This one encapsulates the middleware contributed here [1]. I've rewritten it fairly exhaustively and added tests, but it works the same way as the original. [1] riverqueue/river#1073 (comment)
brandur
force-pushed
the
brandur-panictoerror
branch
from
17972e6 to
5d0d5ca
Compare
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one encapsulates the middleware contributed here [1]. I've
rewritten it fairly exhaustively and added tests, but it works the same
way as the original.
[1] riverqueue/river#1073 (comment)