Fix nilerror's compliance with HookWorkEnd interface
#30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
force-pushed
the
brandur-fix-work-end-interface
branch
4 times, most recently
from
d3b4746 to
38583c8
Compare
Some time back, soon after releasing `HookWorkEnd` for the first time we ended up making a fast follow up breaking change that added a `JobRow` into the interface. This has been out for quite some time, but `nilerror` was never fixed to reflect it. Also, update `rivershared` and use our new example log helpers.
brandur
force-pushed
the
brandur-fix-work-end-interface
branch
from
38583c8 to
92f48e5
Compare
bgentry
approved these changes
Nov 18, 2025
Contributor
There was a problem hiding this comment.
We should probably upgrade deps for datadog too, they've shipped a lot in the Go client since we released this package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time back, soon after releasing
HookWorkEndfor the first time weended up making a fast follow up breaking change that added a
JobRowinto the interface. This has been out for quite some time, but
nilerrorwas never fixed to reflect it.
Also, update
riversharedand use our new example log helpers.