More complete example test for nilerror
#27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
force-pushed
the
brandur-complete-example
branch
5 times, most recently
from
51de789 to
06763a2
Compare
brandur
commented
May 4, 2025
| packageName = packagePath[lastSlash+1:] | ||
| nilPtrName = fmt.Sprintf("(*%s.%s)(<nil>)", packageName, nonPtrType.Name()) | ||
| message = fmt.Sprintf("non-nil error containing nil internal value (see: https://go.dev/doc/faq#nil_error); probably a bug: %s", nilPtrName) | ||
| message = "non-nil error containing nil internal value (see: https://go.dev/doc/faq#nil_error); probably a bug: " + nilPtrName |
Contributor
Author
There was a problem hiding this comment.
Linter did this automatically.
brandur
commented
May 4, 2025
|
|
||
| var logBuf bytes.Buffer | ||
| hook.Archetype.Logger = slog.New(&slogutil.SlogMessageOnlyHandler{Level: slog.LevelWarn, Out: &logBuf}) | ||
| hook.Logger = slog.New(&slogutil.SlogMessageOnlyHandler{Level: slog.LevelWarn, Out: &logBuf}) |
bgentry
approved these changes
May 4, 2025
Now that we have an easy way to raise a full schema in tests through `riverdbtest`, put in a more complete example test for the `nilerror` package. It inserts a job, works the job, and checks for the warning output that we expect the hook to produce.
brandur
force-pushed
the
brandur-complete-example
branch
from
a1d2b83 to
1a3eafc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have an easy way to raise a full schema in tests through
riverdbtest, put in a more complete example test for thenilerrorpackage. It inserts a job, works the job, and checks for the warning
output that we expect the hook to produce.