Deprecate per-operation middleware operation defaults #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
force-pushed
the
brandur-deprecate-per-middleware-defaults
branch
from
7080a05 to
b4f7ce6
Compare
bgentry
approved these changes
Mar 24, 2025
brandur
force-pushed
the
brandur-deprecate-per-middleware-defaults
branch
from
d884958 to
bde1cd8
Compare
As per #804, middleware has been restructed to look more like the design of hooks, and I was finding that as I restructuring documentation as part of [1] it was hard to recommend the use of per-operation middleware defaults. Here, deprecate the per-operation defaults in favor of just the single `river.MiddlewareDefaults` struct. This should also be somewhat more beneficial in case more middleware operations need to be added in the future because we'll just have fewer total new types emerge out of it. [1] riverqueue/homepage#198
brandur
force-pushed
the
brandur-deprecate-per-middleware-defaults
branch
from
bde1cd8 to
93b1c38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #804, middleware has been restructed to look more like the design
of hooks, and I was finding that as I restructuring documentation as
part of [1] it was hard to recommend the use of per-operation middleware
defaults.
Here, deprecate the per-operation defaults in favor of just the single
river.MiddlewareDefaultsstruct. This should also be somewhat morebeneficial in case more middleware operations need to be added in the
future because we'll just have fewer total new types emerge out of it.
[1] https://github.com/riverqueue/homepage/pull/198