Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect non-zero ScheduledAt from JobArgsWithInsertOpts #487

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

bgentry
Copy link
Contributor

@bgentry bgentry commented Jul 31, 2024

This allows for job arg definitions to utilize custom logic at the args level for determining when the job should be scheduled.

Fixes #484.

@bgentry bgentry requested a review from brandur July 31, 2024 13:59
@bgentry bgentry force-pushed the bg-respect-scheduled-at-on-job-args-insert-opts branch from 5be1df0 to 61dd212 Compare July 31, 2024 14:00
@bgentry bgentry force-pushed the bg-respect-scheduled-at-on-job-args-insert-opts branch from 61dd212 to fa11038 Compare July 31, 2024 14:02
This allows for job arg definitions to utilize custom logic at the args
level for determining when the job should be scheduled.

Fixes #484.
@bgentry bgentry force-pushed the bg-respect-scheduled-at-on-job-args-insert-opts branch from fa11038 to 678a78b Compare July 31, 2024 14:33
@bgentry bgentry enabled auto-merge (squash) July 31, 2024 14:33
@bgentry bgentry merged commit 315cc9a into master Jul 31, 2024
10 checks passed
@bgentry bgentry deleted the bg-respect-scheduled-at-on-job-args-insert-opts branch July 31, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ScheduledAt insert option doesn't work from JobArgsWithInsertOpts
2 participants