Move parts of the project over to rivershared
#428
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed over Slack, we've been having trouble wherein we often find
ourselves needing pieces of the main River Go project over in other
projects like River UI, and having to copy a bunch of stuff over.
Here, we establish a new
rivershared
repository in [1], then movereferences to it in the main repository over.
Basically my methodology for this one is that I'd been working on the
plugin system, wanted to see if
startstop.Service
could be moved so wedidn't have to duplicate it in
rivertype
, moved it torivershared
,then moved all of its dependencies over to
rivershared
as well. (Mostof these dependencies come from
startstop
's test suite.)[1] https://github.com/riverqueue/rivershared/pull/1