Periodic job enqueuer: Set scheduled_at according to expected next run time
#341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
force-pushed
the
brandur-schedule-periodic-jobs-according-to-next-run-at
branch
from
325d349 to
338bc7d
Compare
brandur
force-pushed
the
brandur-schedule-periodic-jobs-according-to-next-run-at
branch
from
338bc7d to
6a27ea0
Compare
bgentry
approved these changes
May 7, 2024
|
Awesome stuff, thank you! |
brandur
force-pushed
the
brandur-schedule-periodic-jobs-according-to-next-run-at
branch
from
6a27ea0 to
14dcd5d
Compare
|
Thanks guys. I unset this as resolving #340 since there's still a little discussion going over there. |
…run time Currently, a periodic job that's inserted gets a value in `scheduled_at` that defaults to the database's `now()`. Here, we alter this with a minor nicety requested in #340 wherein we set `scheduled_at` to the precise time we expected a periodic job to be scheduled. This value is will be very close to `now()`, but likely a little sooner because there's some lag in the insert loop between when job insert params are generated and when the insert happens. Jobs are inserted with state `available` (rather than `scheduled`), so this should have very little functional effect. In a busy system it may cause the periodic jobs to be favored slightly because when locking available jobs, `scheduled_at` is one of the fields we order on for priority.
brandur
force-pushed
the
brandur-schedule-periodic-jobs-according-to-next-run-at
branch
from
14dcd5d to
e5d8638
Compare
brandur
deleted the
brandur-schedule-periodic-jobs-according-to-next-run-at
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a periodic job that's inserted gets a value in
scheduled_atthat defaults to the database's
now(). Here, we alter this with aminor nicety requested in #340 wherein we set
scheduled_atto theprecise time we expected a periodic job to be scheduled. This value is
will be very close to
now(), but likely a little sooner becausethere's some lag in the insert loop between when job insert params are
generated and when the insert happens.
Jobs are inserted with state
available(rather thanscheduled), sothis should have very little functional effect. In a busy system it may
cause the periodic jobs to be favored slightly because when locking
available jobs,
scheduled_atis one of the fields we order on forpriority.