Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elector: Add TTL padding on initial election as well #219

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

brandur
Copy link
Contributor

@brandur brandur commented Feb 19, 2024

Follows up #217 to add TTL padding on the elector's initial election
attempt in addition to adding it to reelection attempts as was done
previously. We move the TTL calculation to a struct variable for easier
and more foolproof access, and to be able put a comment on it.

Copy link
Contributor

@bgentry bgentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Follows up #217 to add TTL padding on the elector's initial election
attempt in addition to adding it to reelection attempts as was done
previously. We move the TTL calculation to a struct variable for easier
and more foolproof access, and to be able put a comment on it.
@brandur brandur force-pushed the brandur-expanded-ttl-one-initial-elect branch from 7117af9 to ab3afb9 Compare February 19, 2024 20:11
@brandur
Copy link
Contributor Author

brandur commented Feb 19, 2024

TY.

@brandur brandur merged commit 6475907 into master Feb 19, 2024
9 of 10 checks passed
@brandur brandur deleted the brandur-expanded-ttl-one-initial-elect branch February 19, 2024 20:15
brandur added a commit that referenced this pull request Feb 19, 2024
Prepares a new release for `v0.0.22`, which brings in one more
leadership election bug fix from #219.
@brandur brandur mentioned this pull request Feb 19, 2024
brandur added a commit that referenced this pull request Feb 19, 2024
Prepares a new release for `v0.0.22`, which brings in one more
leadership election bug fix from #219.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants