tweak JobRetry to reset ScheduledAt in most cases #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A job which has already completed will have a ScheduledAt that could be long in the past. Now that we're re-scheduling it, we should update that to the current time to slot it in alongside other recently-scheduled jobs and not skip the line. Also, its wait duration can't be calculated accurately if we don't reset the ScheduledAt (it could show days of wait time even if it was picked up immediately after being retried).
bgentry
force-pushed
the
bg-job-retry-immediately-fix
branch
from
f4cc249 to
9fc772a
Compare
brandur
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change in behavior on #190.
A job which has already completed will have a
ScheduledAtthat could be long in the past. Now that we're re-scheduling it, we should update that to the current time to slot it in alongside other recently-scheduled jobs and not skip the line. Also, its wait duration can't be calculated accurately if we don't reset theScheduledAt(it could show days of wait time even if it was picked up immediately after being retried).The only time we will continue to avoid touching
ScheduledAthere is for an already-available job with aScheduledAtin the past.