-
Notifications
You must be signed in to change notification settings - Fork 66
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Stop audio in iOS when backgrounded.
- Fixes a crash when a sound is still playing and Artboard is de-allocated. Easy to cause with long sounds as sound resources would get nuked and the engine would keep trying to decode from a dead buffer. - Stops audio when going in background, resumes when coming to foreground. The way I did the backgrounding is on the RiveRendererView as I couldn't find a better general spot to do this but maybe @mjtalbot has an idea. This does not stop long sounds (like songs) when exiting a view, we can address that separately... Diffs= 4a9947630 Stop audio in iOS when backgrounded. (#7055) Co-authored-by: Luigi Rosso <luigi-rosso@users.noreply.github.com>
- Loading branch information
1 parent
e824aa8
commit ff8648e
Showing
4 changed files
with
32 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
cb2ea5b2d31eb6888a96cb25524392087bdf47c7 | ||
4a9947630d3848ff70813cf5e2d8718adb9a1b90 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
0eeb44647783f7ad0fc3607c9f7be76bce9fdea4 | ||
ecf23d0e1921e3d8318e2c9a75f18911aa4daaf4 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule rive-cpp
updated
from 70dfed to ae49ac
ff8648e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change may be the cause of this issue
Other music apps having their music stops when a new app is launched and displayed a Rive component
Is there any plan to fix?
Thanks in advance