Skip to content

Commit

Permalink
Fix for runtime crash with skins nested in solo nodes.
Browse files Browse the repository at this point in the history 
Fixes a crash @HayesGordon caught when using the GameKit. Turns out it's a bug in the C++ runtime with loading of skins inside of nested solo nodes.

We used to resolve the parent of a skin in the "onAddedClean" cycle as it assumed onDirty would only be called after load. Solos can now call that during the "onAddedClean" cycle. We can do the same logic "onAddedDirty" and then the onDirty calls will only happen after we've ascertained we have a valid skinnable parent, so the assumptions still hold.

Diffs=
9266e0d30 Fix for runtime crash with skins nested in solo nodes. (#5109)
  • Loading branch information
luigi-rosso committed Apr 12, 2023
1 parent ec033a1 commit 41cea61
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .rive_head
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2701dee5555698a3bb9ff2e46a57072d9903dd7b
9266e0d308fa635b6cd9e037fa75c7b88cdb7a87
2 changes: 1 addition & 1 deletion submodules/rive-cpp
Submodule rive-cpp updated from c1d7d9 to 1eb7ac

0 comments on commit 41cea61

Please sign in to comment.