Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alt+l key binding breaks '@' symbol on German keyboards #38

Closed
jnslxndr opened this issue Nov 2, 2017 · 8 comments
Closed

alt+l key binding breaks '@' symbol on German keyboards #38

jnslxndr opened this issue Nov 2, 2017 · 8 comments
Assignees
Labels

Comments

@jnslxndr
Copy link

jnslxndr commented Nov 2, 2017

This extension is the one I was looking for so long 😃 Very excellent and it works seamlessly. Thanks a lot!

Unfortunately the default keybindings to start and stop the server break the @ symbol on German keyboards - which is located on alt-l. I had to counter the bindings in my settings with:

[
    {
        "key": "alt+l o",
        "command": "-extension.liveServer.goOnline",
    },
    {
        "key": "alt+l c",
        "command": "-extension.liveServer.goOffline",
    }
]

As I am working mostly with Students new to the field this is rather cumbersome. Would there be a way to introduce the keybindings as optionally?

@jnslxndr
Copy link
Author

jnslxndr commented Nov 2, 2017

Note: This is only concerns macOS users. The Windows and Linux keyboard layout is different.

@ritwickdey
Copy link
Owner

ritwickdey commented Nov 2, 2017

I don't have MacOS. Can you suggest me about the key bindings for macOS?

@ritwickdey
Copy link
Owner

I can add platform specific key bindings!

@jnslxndr
Copy link
Author

jnslxndr commented Nov 6, 2017

Excellent. That would be great! 👍

On macOS I suggest it to be cmd+L [O|C].

@timblanq
Copy link

+1

@ritwickdey
Copy link
Owner

Hi, I'm sorry, I was too busy. Today (after few min) I'll fix the issue.. (I'm apologize for it)

@ritwickdey ritwickdey self-assigned this Dec 19, 2017
ritwickdey added a commit that referenced this issue Dec 19, 2017
@ritwickdey
Copy link
Owner

This issue has been resolved with v3.0.2. Please update the extension and thanks for the reporting.

If you like the extension, please drop a review to vscode marketplace.

& let me know if it's still does not work for you. (I don't have MAC).

ritwickdey added a commit that referenced this issue Dec 19, 2017
@jnslxndr
Copy link
Author

Thanks for the fix!! :-)
Will try asap; also too busy at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants